Skip to content

Commit

Permalink
tools/power turbostat: fix un-intended affinity of forked program
Browse files Browse the repository at this point in the history
Linux 3.4 included a modification to turbostat to
lower cross-call overhead by using scheduler affinity:

15aaa34
(tools turbostat: reduce measurement overhead due to IPIs)

In the use-case where turbostat forks a child program,
that change had the un-intended side-effect of binding
the child to the last cpu in the system.

This change removed the binding before forking the child.

This is a back-port of a fix already included in turbostat v2.

Signed-off-by: Len Brown <len.brown@intel.com>
  • Loading branch information
lenb committed Jun 4, 2012
1 parent f8f5701 commit d15cf7c
Showing 1 changed file with 26 additions and 2 deletions.
28 changes: 26 additions & 2 deletions tools/power/x86/turbostat/turbostat.c
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@ int backwards_count;
char *progname;

int num_cpus;
cpu_set_t *cpu_mask;
size_t cpu_mask_size;
cpu_set_t *cpu_present_set, *cpu_mask;
size_t cpu_present_setsize, cpu_mask_size;

struct counters {
unsigned long long tsc; /* per thread */
Expand Down Expand Up @@ -103,6 +103,12 @@ struct timeval tv_even;
struct timeval tv_odd;
struct timeval tv_delta;

int mark_cpu_present(int pkg, int core, int cpu)
{
CPU_SET_S(cpu, cpu_present_setsize, cpu_present_set);
return 0;
}

/*
* cpu_mask_init(ncpus)
*
Expand All @@ -118,13 +124,28 @@ void cpu_mask_init(int ncpus)
}
cpu_mask_size = CPU_ALLOC_SIZE(ncpus);
CPU_ZERO_S(cpu_mask_size, cpu_mask);

/*
* Allocate and initialize cpu_present_set
*/
cpu_present_set = CPU_ALLOC(ncpus);
if (cpu_present_set == NULL) {
perror("CPU_ALLOC");
exit(3);
}
cpu_present_setsize = CPU_ALLOC_SIZE(ncpus);
CPU_ZERO_S(cpu_present_setsize, cpu_present_set);
for_all_cpus(mark_cpu_present);
}

void cpu_mask_uninit()
{
CPU_FREE(cpu_mask);
cpu_mask = NULL;
cpu_mask_size = 0;
CPU_FREE(cpu_present_set);
cpu_present_set = NULL;
cpu_present_setsize = 0;
}

int cpu_migrate(int cpu)
Expand Down Expand Up @@ -1047,6 +1068,9 @@ int fork_it(char **argv)
int retval;
pid_t child_pid;
get_counters(cnt_even);

/* clear affinity side-effect of get_counters() */
sched_setaffinity(0, cpu_present_setsize, cpu_present_set);
gettimeofday(&tv_even, (struct timezone *)NULL);

child_pid = fork();
Expand Down

0 comments on commit d15cf7c

Please sign in to comment.