Skip to content

Commit

Permalink
counter: 104-quad-8: Add lock guards - filter clock prescaler
Browse files Browse the repository at this point in the history
Add lock protection from race conditions to the 104-quad-8 counter
driver for filter clock prescaler code changes. Mutex calls used for
protection.

Signed-off-by: Syed Nayyar Waris <syednwaris@gmail.com>
Fixes: de65d05 ("counter: 104-quad-8: Support Filter Clock Prescaler")
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
  • Loading branch information
Syed Nayyar Waris authored and jic23 committed Jun 14, 2020
1 parent 708d989 commit d5ed76a
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions drivers/counter/104-quad-8.c
Original file line number Diff line number Diff line change
Expand Up @@ -1365,6 +1365,8 @@ static ssize_t quad8_signal_fck_prescaler_write(struct counter_device *counter,
if (ret)
return ret;

mutex_lock(&priv->lock);

priv->fck_prescaler[channel_id] = prescaler;

/* Reset Byte Pointer */
Expand All @@ -1375,6 +1377,8 @@ static ssize_t quad8_signal_fck_prescaler_write(struct counter_device *counter,
outb(QUAD8_CTR_RLD | QUAD8_RLD_RESET_BP | QUAD8_RLD_PRESET_PSC,
base_offset + 1);

mutex_unlock(&priv->lock);

return len;
}

Expand Down

0 comments on commit d5ed76a

Please sign in to comment.