Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Morse Code FAP #144

Merged
merged 2 commits into from
Nov 1, 2022
Merged

Morse Code FAP #144

merged 2 commits into from
Nov 1, 2022

Conversation

wh00hw
Copy link
Contributor

@wh00hw wh00hw commented Nov 1, 2022

What's new

  • Add Morse Code parser FAP

@wh00hw wh00hw requested a review from xMasterX as a code owner November 1, 2022 10:12
xMasterX
xMasterX approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@xMasterX xMasterX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, but needs some way to reset text on screen without exiting the app
Or maybe make it scroll endless
If you want to improve it, make a new PR after, for now I will accept current version
Thanks

@xMasterX xMasterX merged commit ee665e1 into DarkFlippers:dev Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xMasterX xMasterX xMasterX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wh00hw @xMasterX