Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[infrared]: allow disabling automatic signal decoding #273

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

darmiel
Copy link
Contributor

@darmiel darmiel commented Jan 8, 2023

What's new

Adds a new menu item Lean New Remote RAW in the Infrared App, which is only visible when the debug mode is enabled in the settings. When used, automatic decoding of signals is prevented -> you always get a raw capture.

Screen.Recording.2023-01-08.at.02.07.47.mov

Verification

  • Verify that debug mode is disabled (Settings -> System -> Debug -> OFF)
  • Open the Infrared app
  • Learn New Remote RAW should be missing
  • Verify that debug mode is enabled (Settings -> System -> Debug -> ON)
  • Open the Infrared app
  • Learn New Remote RAW should be available
  • Use Learn New Remote and verify that signals are decoded
  • Use Learn New Remote RAW and verify that signals are not decoded

Checklist (For Reviewer)

  • PR has description of feature/bug
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@darmiel darmiel requested a review from xMasterX as a code owner January 8, 2023 13:40
@amec0e
Copy link
Member

amec0e commented Jan 11, 2023

Fiya! 🔥

@forid786
Copy link

Why bother hiding the option when Settings > System > Debug is off? You may as well always make it visible and have some consistency with the Sub Ghz app.

@xMasterX
Copy link
Member

Why bother hiding the option when Settings > System > Debug is off? You may as well always make it visible and have some consistency with the Sub Ghz app.

No, it is not needed for regular usage, normal learn captures raw data if it cannot decode it
This function forces it to disable decoding which is shouldn’t be available to regular users

hiding it in debug is a requirement to have that functionality

@forid786
Copy link

Ah okay, yeah that makes sense. Completely forgot that it does automatically fall back to RAW when it cannot decode it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants