Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove keyword search cruft #3580

Closed
dsotirho-ucsc opened this issue Oct 26, 2021 · 0 comments
Closed

Remove keyword search cruft #3580

dsotirho-ucsc opened this issue Oct 26, 2021 · 0 comments
Assignees
@hannes-ucsc
Labels
debt [type] A defect incurring continued engineering cost enh [type] New feature or request no demo [process] Not to be demonstrated at the end of the sprint orange [process] Done by the Azul team service [subject] The service part of Azul

Comments

@dsotirho-ucsc
Copy link
Contributor

dsotirho-ucsc commented Oct 26, 2021 •
edited
Loading

Regression from 68be452

For example: pagination can never be None, remove the if branch for that case, remove KeywordSearchResponse from the response class hierarchy. Remove any other dead code.
@github-actions github-actions bot added the orange [process] Done by the Azul team label Oct 26, 2021
@dsotirho-ucsc dsotirho-ucsc added code [subject] Production code debt [type] A defect incurring continued engineering cost enh [type] New feature or request and removed orange [process] Done by the Azul team labels Oct 26, 2021
@dsotirho-ucsc dsotirho-ucsc self-assigned this Oct 26, 2021
@github-actions github-actions bot added the orange [process] Done by the Azul team label Oct 26, 2021
@hannes-ucsc hannes-ucsc self-assigned this Apr 5, 2022
@hannes-ucsc hannes-ucsc added service [subject] The service part of Azul and removed code [subject] Production code labels Apr 5, 2022
@hannes-ucsc hannes-ucsc mentioned this issue Apr 5, 2022
Merged
57 tasks
hannes-ucsc added a commit that referenced this issue Apr 5, 2022
@hannes-ucsc
Remove keyword search cruft (#3580)
362c19d
@hannes-ucsc hannes-ucsc added the no demo [process] Not to be demonstrated at the end of the sprint label Apr 5, 2022
amarjandu added a commit that referenced this issue Apr 5, 2022
@amarjandu
Remove keyword search cruft (#3580, PR #4051)
d56e6ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hannes-ucsc hannes-ucsc

Labels
debt [type] A defect incurring continued engineering cost enh [type] New feature or request no demo [process] Not to be demonstrated at the end of the sprint orange [process] Done by the Azul team service [subject] The service part of Azul
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hannes-ucsc @theathorn @dsotirho-ucsc