Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index dcp15 in prod (#4015) #4029

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Conversation

amarjandu
Copy link
Contributor

@amarjandu amarjandu commented Apr 2, 2022

Connected issue: #4015

Checklist

Author

  • Target branch is develop
  • Source branch is issues/<github-handle>/<issue#>-<slug>
  • PR title references the connected issue
  • PR title matches1 title of connected issue or comment in PR explains why they're different
  • Title of at least one commit references connected issue
  • PR is connected to issue via Zenhub
  • PR description links to connected issue
  • Added partial label to PR or this PR completely resolves the connected issue

1 when the issue title describes a problem, the PR title is Fix: followed by the issue title

Author (reindex)

  • Added r tag to commit title or this PR does not require reindexing
  • Added reindex label to PR or this PR does not require reindexing

Author (chains)

  • This PR is blocked by previous PR in the chain or this PR is not chained to another PR
  • Added chain label to the blocking PR or this PR is not chained to another PR

Author (upgrading)

  • Documented upgrading of deployments in UPGRADING.rst or this PR does not require upgrading
  • Added u tag to commit title or this PR does not require upgrading
  • Added upgrade label to PR or this PR does not require upgrading

Author (operator tasks)

  • Added checklist items for additional operator tasks or this PR does not require additional tasks

Author (hotfixes)

  • Added F tag to main commit title or this PR does not include permanent fix for a temporary hotfix
  • Reverted the temporary hotfix connected to the issue or there is no temporary hotfix for the connected issue on the prod branch

Author (requirements)

  • Ran make requirements_update or this PR does not touch requirements*.txt, common.mk, Makefile and Dockerfile
  • Added R tag to commit title or this PR does not touch requirements*.txt
  • Added reqs label to PR or this PR does not touch requirements*.txt

Author (rebasing, integration test)

  • make integration_test passes in personal deployment or this PR does not touch functionality that could break the IT
  • Rebased branch on develop, squashed old fixups

Primary reviewer (after rejection)

Uncheck the Author (requirements) and Author (rebasing, integration test)
checklists.

Primary reviewer (after approval)

  • Actually approved the PR
  • Labeled connected issue as demo or no demo
  • Commented on connected issue about demo expectations or labelled connected issue as no demo
  • Decided if PR can be labeled no sandbox
  • PR title is appropriate as title of merge commit
  • Ticket is in Review requested column
  • Requested review from peer reviewer
  • Assigned PR to peer reviewer

Peer reviewer (after rejection)

Uncheck the Author (requirements) and Author (rebasing, integration test)
checklists.

Peer reviewer (after approval)

  • N reviews label on PR reflects prior peer reviews with changes requested
  • Moved ticket to Approved column
  • Assigned PR to current operator

Operator (before pushing merge the commit)

  • Checked reindex label and r commit title tag
  • Checked that demo expectations are clear or connected issue is labeled as no demo
  • Rebased and squashed branch
  • Sanity-checked history
  • Pushed PR branch to GitHub
  • Branch pushed to GitLab and added sandbox label or PR is labeled no sandbox
  • Build passed in sandbox or PR is labeled no sandbox
  • Started reindex in sandbox or this PR does not require reindexing sandbox
  • Checked for failures in sandbox or this PR does not require reindexing sandbox
  • Added PR reference to merge commit title
  • Collected commit title tags in merge commit title
  • Moved connected issue to Merged column
  • Pushed merge commit to GitHub

Operator (after pushing the merge commit)

  • Shortened the PR chain or this PR is not labeled chain
  • Pushed merge commit to GitLab or merge commit can be pushed later, with another PR
  • Deleted PR branch from GitHub and GitLab
  • Build passes on GitLab

Operator (reindex)

  • Started reindex in dev or this PR does not require reindexing
  • Checked for and triaged indexing failures or this PR does not require reindexing
  • Emptied fail queues in target deployment or this PR does not require reindexing

Operator

  • Unassigned PR

Shorthand for review comments

  • L line is too long
  • W line wrapping is wrong
  • Q bad quotes
  • F other formatting problem

@github-actions github-actions bot added the orange [process] Done by the Azul team label Apr 2, 2022
@amarjandu
Copy link
Contributor Author

Self note: verified by _select prod

from azul import config
len(config.catalogs['dcp15'].sources)
237

@codecov
Copy link

codecov bot commented Apr 2, 2022

Codecov Report

Merging #4029 (874f5d8) into develop (5740761) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #4029   +/-   ##
========================================
  Coverage    81.64%   81.64%           
========================================
  Files          125      125           
  Lines        15263    15263           
========================================
  Hits         12461    12461           
  Misses        2802     2802           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5740761...874f5d8. Read the comment docs.

@coveralls
Copy link

coveralls commented Apr 2, 2022

Coverage Status

Coverage remained the same at 81.853% when pulling 874f5d8 on issues/amar/4015-add-dcp15 into 5740761 on develop.

@hannes-ucsc hannes-ucsc added the no sandbox [process] PR will not be tested in the sandbox label Apr 4, 2022
@achave11-ucsc achave11-ucsc added the 0 reviews [process] Lead didn't request any changes label Apr 5, 2022
@amarjandu amarjandu merged commit 293f8ab into develop Apr 5, 2022
@amarjandu amarjandu deleted the issues/amar/4015-add-dcp15 branch April 5, 2022 17:13
@amarjandu amarjandu removed their assignment Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 reviews [process] Lead didn't request any changes no sandbox [process] PR will not be tested in the sandbox orange [process] Done by the Azul team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants