[revive] allow unused variables starting with underscore

[pgimalac]

What does this PR do?

Allow using variables starting with underscore without revive complaining it's unused.

Motivation

_ is not explicit on what the variable is, and it can be useful to make it clear even when the variable is unused.
In that case, allowing using _somename is useful.

Additional Notes

Feature added in mgechev/revive#858.

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

I tested manually that it worked as expected.

[pr-commenter]

Regression Detector

Regression Detector Results

Run ID: 7d9953ff-422c-4767-99ac-5600b5daeac7 Metrics dashboard Target profiles

Baseline: 2393b39
Comparison: 06b7700

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	links
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+1.71	[+0.83, +2.60]	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+1.61	[-11.19, +14.40]	Logs
➖	otel_to_otel_logs	ingress throughput	+0.55	[-0.27, +1.36]	Logs
➖	basic_py_check	% cpu utilization	+0.45	[-2.12, +3.03]	Logs
➖	file_tree	memory utilization	+0.11	[+0.05, +0.17]	Logs
➖	idle	memory utilization	+0.06	[+0.03, +0.10]	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.00, +0.00]	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.01, +0.01]	Logs
➖	pycheck_1000_100byte_tags	% cpu utilization	-0.69	[-5.47, +4.08]	Logs

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[pgimalac]

/merge

[dd-devflow]

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 23m.

Use /merge -c to cancel this operation!