Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USMON-1152: Remove Kafka monitor tests optimization #29143

Merged

Conversation

DanielLavie
Copy link
Contributor

What does this PR do?

Remove cleanProtocolMaps optimization from kafka_monitor_test.go.

Motivation

While investigating the flaky Kafka tests, we discovered that the cleanProtocolMaps function is failing with per-cpu maps used by the Kafka monitoring eBPF programs, which could potentially cause map leaks. Therefore, we are removing this optimization temporarily until a fix is identified for this issue

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@DanielLavie DanielLavie requested a review from a team as a code owner September 9, 2024 13:05
@DanielLavie DanielLavie added team/usm The USM team changelog/no-changelog qa/done Skip QA week as QA was done before merge and regressions are covered by tests labels Sep 9, 2024
@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 43851516 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@pr-commenter
Copy link

pr-commenter bot commented Sep 9, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=43851516 --os-family=ubuntu

Note: This applies to commit 7ca27ca

@pr-commenter
Copy link

pr-commenter bot commented Sep 9, 2024

Regression Detector

Regression Detector Results

Run ID: 30c71a8d-b808-4cca-a743-868d92f32bca Metrics dashboard Target profiles

Baseline: e9cee3d
Comparison: 7ca27ca

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
basic_py_check % cpu utilization +0.49 [-2.29, +3.26] 1 Logs
file_tree memory utilization +0.22 [+0.18, +0.26] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.19 [-0.59, +0.97] 1 Logs
idle memory utilization +0.16 [+0.12, +0.20] 1 Logs
pycheck_lots_of_tags % cpu utilization +0.14 [-2.36, +2.64] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
otel_to_otel_logs ingress throughput -0.82 [-1.63, -0.02] 1 Logs
tcp_syslog_to_blackhole ingress throughput -2.35 [-15.04, +10.34] 1 Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
idle memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@DanielLavie
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Sep 9, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 23m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit e6c04b1 into main Sep 9, 2024
319 of 321 checks passed
@dd-mergequeue dd-mergequeue bot deleted the daniel.lavie/USMON-1152-remove-kafka-test-optimization branch September 9, 2024 15:29
@github-actions github-actions bot added this to the 7.59.0 milestone Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe qa/done Skip QA week as QA was done before merge and regressions are covered by tests team/usm The USM team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants