[E2E] Retry Agent MSI download #29352
Conversation
clarkb7
added
changelog/no-changelog
team/windows-agent
qa/no-code-change
This reverts commit 36b4f64.
|
[Fast Unit Tests Report] On pipeline 44337972 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help |
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=44337972 --os-family=ubuntuNote: This applies to commit ee5c1a4 |
Regression DetectorRegression Detector ResultsRun ID: 6576755f-c8e7-4e9c-9ccc-9e0171a32846 Metrics dashboard Target profiles Baseline: a0be446 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | pycheck_lots_of_tags | % cpu utilization | +0.68 | [-2.01, +3.38] | 1 | Logs |
| ➖ | otel_to_otel_logs | ingress throughput | +0.50 | [-0.33, +1.33] | 1 | Logs |
| ➖ | basic_py_check | % cpu utilization | +0.44 | [-2.35, +3.23] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | idle | memory utilization | -0.03 | [-0.07, +0.01] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.25 | [-0.30, -0.20] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.30 | [-0.40, -0.19] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -1.15 | [-1.90, -0.39] | 1 | Logs |
Bounds Checks
| perf | experiment | bounds_check_name | replicates_passed |
|---|---|---|---|
| ❌ | idle | memory_usage | 5/10 |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
| if strings.HasPrefix(url, "http://") || strings.HasPrefix(url, "https://") { | ||
| return DownloadFile(host, url, destination) | ||
| err := backoff.Retry(func() error { |
There was a problem hiding this comment.
❓ question
Would it be possible to pass a testing.T context in the signature, so that we could use testify.Eventually instead of backoff? We had plans to remove backoff from test/new-e2e as it is all code uses in tests, makes sense when possible to use testing features.
There was a problem hiding this comment.
I'm trying to avoid testify.Eventually in code that isn't specifically a test due to the issues we've encountered with it. Have those been resolved, yet?
There was a problem hiding this comment.
Which issue did you encounter?
There was a problem hiding this comment.
testify.Eventually waits for the delay interval once before calling the condition function.
There was a problem hiding this comment.
The PR that checks the condition before running the delayed loop is still open. Is this a blocker in this case? In other words, do you expect for the condition to be possibly true at time 0?
There was a problem hiding this comment.
the download succeeding the first time is the 99% case yes.
There was a problem hiding this comment.
What about reducing the interval to 1 second, so worst case, while the feature is not integrated, you lose 1 second? I am trying to remove backoff from test/new-e2e to have one golden path for handling retries, if this is urgent we can revisit in the near future, but I'd rather lose 1 second at install time while testify fixes this than having 2 different ways to retry in the code, which can be misleading.
|
/merge |
|
🚂 MergeQueue: waiting for PR to be ready This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
|
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
What does this PR do?
Adds a retry mechanism to downloading the Agent MSI during MSI E2E tests.
Retries for up to 5 minutes.
Motivation
https://datadoghq.atlassian.net/browse/WINA-809
reverts #29323
Additional Notes
Does not apply to Agent E2E tests using test-infra to install the Agent
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
N/A, test change