Enable device scan command

[NouhaManai96]

What does this PR do?

Enable device scan command

Motivation

Enable device scan command

Describe how to test/QA your changes

Simply running agent snmp scan --help should return the command help.
You can also try doing an actual scan with agent snmp scan <ipaddress>[:port] [flags].

Possible Drawbacks / Trade-offs

Additional Notes

[pr-commenter]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=46292309 --os-family=ubuntu

Note: This applies to commit de2d141

[urseberry]

capitalization nit

[dplepage-dd]

I don't think we want a changelog entry since it's a hidden feature; this PR may also be unnecessary given Florian's #29148, which provides the command via the dependency injector and does mark it as hidden

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 087fb584-2d5d-4a68-a8ce-78721624afb8

Baseline: a2bbdf1
Comparison: de2d141

Regression Detector: ✅

Bounds Checks: ✅

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	basic_py_check	% cpu utilization	+1.79	[-2.19, +5.77]	1	Logs
➖	pycheck_lots_of_tags	% cpu utilization	+1.28	[-2.28, +4.84]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+1.07	[+1.00, +1.14]	1	Logs
➖	idle	memory utilization	+0.79	[+0.75, +0.84]	1	Logs
➖	file_tree	memory utilization	+0.16	[+0.05, +0.27]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.12	[-0.37, +0.61]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.04	[-0.20, +0.29]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.01	[-0.21, +0.23]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.10, +0.11]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.01, +0.01]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.02	[-0.36, +0.32]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.04	[-0.22, +0.13]	1	Logs
➖	otel_to_otel_logs	ingress throughput	-0.30	[-1.11, +0.51]	1	Logs
➖	idle_all_features	memory utilization	-0.47	[-0.56, -0.38]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-3.34	[-4.05, -2.64]	1	Logs

Bounds Checks Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	idle	memory_usage	10/10

Explanation

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[dd-devflow]

⚠️ Devflow: /mergex

Action not found: mergex

If you need support, contact us on Slack #devflow!

[NouhaManai96]

/merge

[dd-devflow]

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 26m.

Use /merge -c to cancel this operation!