Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gitlab configuration check to not crash on job without rules #29558

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Fix gitlab configuration check to not crash on job without rules #29558

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tasks/linter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,7 +613,9 @@ def contains_valid_change_rule(rule):
tests_without_change_path = defaultdict(list)
tests_without_change_path_allowed = defaultdict(list)
for test, filepath in tests:
if not any(contains_valid_change_rule(rule) for rule in config[test]['rules'] if isinstance(rule, dict)):
if "rules" in config[test] and not any(
contains_valid_change_rule(rule) for rule in config[test]['rules'] if isinstance(rule, dict)
):
if test in tests_without_change_path_allow_list:
tests_without_change_path_allowed[filepath].append(test)
else:
Expand Down
Loading