Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discovery: report containerID for containerised services #29719

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

discovery: report containerID for containerised services #29719

wants to merge 5 commits into from
+132 −22

Commits on Oct 8, 2024

  1. discovery: add containerID field to SD structs

    @Yumasi
    Yumasi committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    21e56f9 View commit details
    Browse the repository at this point in the history

  2. discovery: provide workloadmeta store to discovery check

    @Yumasi
    Yumasi committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    3a2c349 View commit details
    Browse the repository at this point in the history

  3. discovery: add containerID information to discovered services

    @Yumasi
    Yumasi committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    1f3f296 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. test: add containerID checks to test

    @Yumasi
    Yumasi committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    57ebe91 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. fix CR 

    - Only get container ids if there are previous potential services
- Only add container id on confirmed new services
- Add test for propagation of container id values
- Revert unrelated formatting change made by auto-formatter
    @Yumasi
    Yumasi committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    eab643e View commit details
    Browse the repository at this point in the history