-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CWS] optimized data structure for file cache in SBOM resolver #29977
base: main
Are you sure you want to change the base?
Conversation
[Fast Unit Tests Report] On pipeline 46269779 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help |
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=46269779 --os-family=ubuntu Note: This applies to commit d18d748 |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 52a88e9 Regression Detector: ✅ Bounds Checks: ✅ No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | idle_all_features | memory utilization | +0.52 | [+0.44, +0.61] | 1 | Logs |
➖ | pycheck_lots_of_tags | % cpu utilization | +0.26 | [-3.28, +3.81] | 1 | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.03 | [-0.69, +0.75] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.10, +0.12] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | +0.00 | [-0.04, +0.05] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
➖ | idle | memory utilization | -0.22 | [-0.27, -0.18] | 1 | Logs |
➖ | otel_to_otel_logs | ingress throughput | -0.50 | [-1.30, +0.31] | 1 | Logs |
➖ | file_tree | memory utilization | -1.01 | [-1.13, -0.90] | 1 | Logs |
➖ | basic_py_check | % cpu utilization | -3.39 | [-7.19, +0.41] | 1 | Logs |
Bounds Checks Passed
perf | experiment | bounds_check_name | replicates_passed | links |
---|---|---|---|---|
✅ | idle | memory_usage | 10/10 |
Explanation
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
b0142fa
to
e52c945
Compare
152bff3
to
d18d748
Compare
What does this PR do?
The mapping from file paths to package is currently done through a map. It was shown that on big nodes this can take up to multiple megabytes of data. My performance benchmarks show that on the particular host where this behavior was spotted we go from 17MiB of data stored in
sbom.files
to only ~6/7MiBThis PR introduces an optimized datastructure that allows to store this mapping in a more space-efficient manner, at the cost of a slightly decrease in query performance.
The datastructure layout is explained in the comments.
Motivation
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes