Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RC][FA] Use sync map in repo #30011

Merged
merged 3 commits into from
Oct 10, 2024
Merged

[RC][FA] Use sync map in repo #30011

merged 3 commits into from
Oct 10, 2024

Conversation

coignetp
Copy link
Contributor

What does this PR do?

Use sync.Map for metadata in repository, so clients can concurrently update/get their config state

Motivation

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Oct 10, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=46279134 --os-family=ubuntu

Note: This applies to commit f5ae13f

Copy link

cit-pr-commenter bot commented Oct 10, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: e038d03e-f765-4ef9-89cc-eca032a9fc99

Baseline: b83d36e
Comparison: f5ae13f

Regression Detector: ✅

Bounds Checks: ✅

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +0.80 [+0.07, +1.54] 1 Logs
pycheck_lots_of_tags % cpu utilization +0.38 [-3.12, +3.87] 1 Logs
idle memory utilization +0.18 [+0.14, +0.23] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.10 [-0.40, +0.59] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.03 [-0.21, +0.27] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.00 [-0.33, +0.34] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.00 [-0.22, +0.22] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.02 [-0.12, +0.08] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.08 [-0.26, +0.10] 1 Logs
file_tree memory utilization -0.14 [-0.25, -0.03] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.27 [-0.32, -0.22] 1 Logs
idle_all_features memory utilization -0.69 [-0.79, -0.59] 1 Logs
otel_to_otel_logs ingress throughput -0.91 [-1.71, -0.10] 1 Logs
basic_py_check % cpu utilization -4.29 [-7.96, -0.61] 1 Logs

Bounds Checks Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
idle memory_usage 10/10

Explanation

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@coignetp
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Oct 10, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 27m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit fec4f94 into main Oct 10, 2024
204 of 205 checks passed
@dd-mergequeue dd-mergequeue bot deleted the paul/fa-sync-map branch October 10, 2024 14:44
@github-actions github-actions bot added this to the 7.60.0 milestone Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants