fix(fetch_secret): Transfer the exit code in windows context #30031

chouetz · 2024-10-10T18:10:45Z

What does this PR do?

Currently when facing an Unable to locate credential issue on windows we are not using the retry:exit_codes. To do so we need to transfer the $lastExitCode up to the Gitlab script

Motivation

Have an automatic retry in this situation

Describe how to test/QA your changes

TBD

Possible Drawbacks / Trade-offs

Additional Notes

Currently when facing an `Unable to locate` credential issue on windows we are not using the `retry:exit_codes`. To do so we need to transfer the $lastExitCode up to the Gitlab script

agent-platform-auto-pr · 2024-10-10T18:16:31Z

Gitlab CI Configuration Changes

Modified Jobs

.docker_build_agent7_windows_common

  .docker_build_agent7_windows_common:
    needs:
    - windows_msi_and_bosh_zip_x64-a7
    - build_windows_container_entrypoint
    rules:
    - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
      when: never
    - when: on_success
    script:
    - $ECR_RELEASE_SUFFIX="$(If ($BUCKET_BRANCH -eq `"nightly`") { `"-nightly`" } elseif
      ($CI_COMMIT_TAG) { `"-release`" } else { `"`" })"
    - $TARGET_TAG="${IMAGE}${ECR_RELEASE_SUFFIX}:v${CI_PIPELINE_ID}-${CI_COMMIT_SHORT_SHA}${TAG_SUFFIX}-win${VARIANT}${SERVERCORE}-amd64"
    - $ErrorActionPreference = "Stop"
    - $_instance_id = (iwr  -UseBasicParsing http://169.254.169.254/latest/meta-data/instance-id).content
      ; Write-Host "Running on instance $($_instance_id)"
    - cp ${OMNIBUS_PACKAGE_DIR}/${AGENT_ZIP} ${BUILD_CONTEXT}/datadog-agent-latest.amd64.zip
    - cp entrypoint.exe ${BUILD_CONTEXT}/entrypoint.exe
    - pushd ${BUILD_CONTEXT}
    - Expand-Archive datadog-agent-latest.amd64.zip
    - Remove-Item datadog-agent-latest.amd64.zip
    - Get-ChildItem -Path datadog-agent-* | Rename-Item -NewName "Datadog Agent"
    - popd
    - get-childitem ${BUILD_CONTEXT}
    - 'docker run --rm -w C:\mnt -e AWS_NETWORKING=true -e SIGN_WINDOWS_DD_WCS=true
      -e CI_PIPELINE_ID=${CI_PIPELINE_ID} -e CI_PROJECT_NAME=${CI_PROJECT_NAME} -e DOCKER_REGISTRY_LOGIN=${DOCKER_REGISTRY_LOGIN}
      -e DOCKER_REGISTRY_PWD=${DOCKER_REGISTRY_PWD} -v "$(Get-Location):C:\mnt" -v \\.\pipe\docker_engine:\\.\pipe\docker_engine
      486234852809.dkr.ecr.us-east-1.amazonaws.com/ci/datadog-agent-buildimages/windows_${Env:VARIANT}_x64${Env:DATADOG_AGENT_WINBUILDIMAGES_SUFFIX}:${Env:DATADOG_AGENT_WINBUILDIMAGES}
      powershell -C C:\mnt\tools\ci\docker-login.ps1
  
      '
+   - If ($lastExitCode -eq "42") { exit "$lastExitCode" }
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    - powershell -Command "$(Get-Location)\tools\ci\retry.ps1 docker build --no-cache
      --build-arg GENERAL_ARTIFACTS_CACHE_BUCKET_URL=${GENERAL_ARTIFACTS_CACHE_BUCKET_URL}
      ${BUILD_ARG} --pull --file ${BUILD_CONTEXT}/windows/amd64/Dockerfile --tag ${TARGET_TAG}
      ${BUILD_CONTEXT}"
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    - powershell -Command "$(Get-Location)\tools\ci\retry.ps1 docker push ${TARGET_TAG}"
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    - docker rmi ${TARGET_TAG}
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    stage: container_build
    variables:
      AGENT_ZIP: datadog-agent-7*-x86_64.zip
      BUILD_ARG: --build-arg BASE_IMAGE=mcr.microsoft.com/powershell:lts-nanoserver-${VARIANT}
        --build-arg WITH_JMX=${WITH_JMX} --build-arg VARIANT=${VARIANT} --build-arg
        INSTALL_INFO=nano-${VARIANT}
      BUILD_CONTEXT: Dockerfiles/agent
      IMAGE: registry.ddbuild.io/ci/datadog-agent/agent

.docker_build_agent7_windows_servercore_common

  .docker_build_agent7_windows_servercore_common:
    needs:
    - windows_msi_and_bosh_zip_x64-a7
    - build_windows_container_entrypoint
    rules:
    - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
      when: never
    - when: on_success
    script:
    - $ECR_RELEASE_SUFFIX="$(If ($BUCKET_BRANCH -eq `"nightly`") { `"-nightly`" } elseif
      ($CI_COMMIT_TAG) { `"-release`" } else { `"`" })"
    - $TARGET_TAG="${IMAGE}${ECR_RELEASE_SUFFIX}:v${CI_PIPELINE_ID}-${CI_COMMIT_SHORT_SHA}${TAG_SUFFIX}-win${VARIANT}${SERVERCORE}-amd64"
    - $ErrorActionPreference = "Stop"
    - $_instance_id = (iwr  -UseBasicParsing http://169.254.169.254/latest/meta-data/instance-id).content
      ; Write-Host "Running on instance $($_instance_id)"
    - cp ${OMNIBUS_PACKAGE_DIR}/${AGENT_ZIP} ${BUILD_CONTEXT}/datadog-agent-latest.amd64.zip
    - cp entrypoint.exe ${BUILD_CONTEXT}/entrypoint.exe
    - pushd ${BUILD_CONTEXT}
    - Expand-Archive datadog-agent-latest.amd64.zip
    - Remove-Item datadog-agent-latest.amd64.zip
    - Get-ChildItem -Path datadog-agent-* | Rename-Item -NewName "Datadog Agent"
    - popd
    - get-childitem ${BUILD_CONTEXT}
    - 'docker run --rm -w C:\mnt -e AWS_NETWORKING=true -e SIGN_WINDOWS_DD_WCS=true
      -e CI_PIPELINE_ID=${CI_PIPELINE_ID} -e CI_PROJECT_NAME=${CI_PROJECT_NAME} -e DOCKER_REGISTRY_LOGIN=${DOCKER_REGISTRY_LOGIN}
      -e DOCKER_REGISTRY_PWD=${DOCKER_REGISTRY_PWD} -v "$(Get-Location):C:\mnt" -v \\.\pipe\docker_engine:\\.\pipe\docker_engine
      486234852809.dkr.ecr.us-east-1.amazonaws.com/ci/datadog-agent-buildimages/windows_${Env:VARIANT}_x64${Env:DATADOG_AGENT_WINBUILDIMAGES_SUFFIX}:${Env:DATADOG_AGENT_WINBUILDIMAGES}
      powershell -C C:\mnt\tools\ci\docker-login.ps1
  
      '
+   - If ($lastExitCode -eq "42") { exit "$lastExitCode" }
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    - powershell -Command "$(Get-Location)\tools\ci\retry.ps1 docker build --no-cache
      --build-arg GENERAL_ARTIFACTS_CACHE_BUCKET_URL=${GENERAL_ARTIFACTS_CACHE_BUCKET_URL}
      ${BUILD_ARG} --pull --file ${BUILD_CONTEXT}/windows/amd64/Dockerfile --tag ${TARGET_TAG}
      ${BUILD_CONTEXT}"
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    - powershell -Command "$(Get-Location)\tools\ci\retry.ps1 docker push ${TARGET_TAG}"
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    - docker rmi ${TARGET_TAG}
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    stage: container_build
    variables:
      AGENT_ZIP: datadog-agent-7*-x86_64.zip
      BUILD_ARG: --build-arg BASE_IMAGE=mcr.microsoft.com/powershell:windowsservercore-${VARIANT}
        --build-arg WITH_JMX=${WITH_JMX} --build-arg VARIANT=${VARIANT} --build-arg
        INSTALL_INFO=core-${VARIANT}
      BUILD_CONTEXT: Dockerfiles/agent
      IMAGE: registry.ddbuild.io/ci/datadog-agent/agent
      SERVERCORE: -servercore

.docker_build_agent_windows_common

  .docker_build_agent_windows_common:
    script:
    - $ECR_RELEASE_SUFFIX="$(If ($BUCKET_BRANCH -eq `"nightly`") { `"-nightly`" } elseif
      ($CI_COMMIT_TAG) { `"-release`" } else { `"`" })"
    - $TARGET_TAG="${IMAGE}${ECR_RELEASE_SUFFIX}:v${CI_PIPELINE_ID}-${CI_COMMIT_SHORT_SHA}${TAG_SUFFIX}-win${VARIANT}${SERVERCORE}-amd64"
    - $ErrorActionPreference = "Stop"
    - $_instance_id = (iwr  -UseBasicParsing http://169.254.169.254/latest/meta-data/instance-id).content
      ; Write-Host "Running on instance $($_instance_id)"
    - cp ${OMNIBUS_PACKAGE_DIR}/${AGENT_ZIP} ${BUILD_CONTEXT}/datadog-agent-latest.amd64.zip
    - cp entrypoint.exe ${BUILD_CONTEXT}/entrypoint.exe
    - pushd ${BUILD_CONTEXT}
    - Expand-Archive datadog-agent-latest.amd64.zip
    - Remove-Item datadog-agent-latest.amd64.zip
    - Get-ChildItem -Path datadog-agent-* | Rename-Item -NewName "Datadog Agent"
    - popd
    - get-childitem ${BUILD_CONTEXT}
    - 'docker run --rm -w C:\mnt -e AWS_NETWORKING=true -e SIGN_WINDOWS_DD_WCS=true
      -e CI_PIPELINE_ID=${CI_PIPELINE_ID} -e CI_PROJECT_NAME=${CI_PROJECT_NAME} -e DOCKER_REGISTRY_LOGIN=${DOCKER_REGISTRY_LOGIN}
      -e DOCKER_REGISTRY_PWD=${DOCKER_REGISTRY_PWD} -v "$(Get-Location):C:\mnt" -v \\.\pipe\docker_engine:\\.\pipe\docker_engine
      486234852809.dkr.ecr.us-east-1.amazonaws.com/ci/datadog-agent-buildimages/windows_${Env:VARIANT}_x64${Env:DATADOG_AGENT_WINBUILDIMAGES_SUFFIX}:${Env:DATADOG_AGENT_WINBUILDIMAGES}
      powershell -C C:\mnt\tools\ci\docker-login.ps1
  
      '
+   - If ($lastExitCode -eq "42") { exit "$lastExitCode" }
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    - powershell -Command "$(Get-Location)\tools\ci\retry.ps1 docker build --no-cache
      --build-arg GENERAL_ARTIFACTS_CACHE_BUCKET_URL=${GENERAL_ARTIFACTS_CACHE_BUCKET_URL}
      ${BUILD_ARG} --pull --file ${BUILD_CONTEXT}/windows/amd64/Dockerfile --tag ${TARGET_TAG}
      ${BUILD_CONTEXT}"
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    - powershell -Command "$(Get-Location)\tools\ci\retry.ps1 docker push ${TARGET_TAG}"
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    - docker rmi ${TARGET_TAG}
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    stage: container_build
    variables:
      BUILD_CONTEXT: Dockerfiles/agent
      IMAGE: registry.ddbuild.io/ci/datadog-agent/agent

docker_build_agent7_windows1809

  docker_build_agent7_windows1809:
    needs:
    - windows_msi_and_bosh_zip_x64-a7
    - build_windows_container_entrypoint
    rules:
    - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
      when: never
    - when: on_success
    script:
    - $ECR_RELEASE_SUFFIX="$(If ($BUCKET_BRANCH -eq `"nightly`") { `"-nightly`" } elseif
      ($CI_COMMIT_TAG) { `"-release`" } else { `"`" })"
    - $TARGET_TAG="${IMAGE}${ECR_RELEASE_SUFFIX}:v${CI_PIPELINE_ID}-${CI_COMMIT_SHORT_SHA}${TAG_SUFFIX}-win${VARIANT}${SERVERCORE}-amd64"
    - $ErrorActionPreference = "Stop"
    - $_instance_id = (iwr  -UseBasicParsing http://169.254.169.254/latest/meta-data/instance-id).content
      ; Write-Host "Running on instance $($_instance_id)"
    - cp ${OMNIBUS_PACKAGE_DIR}/${AGENT_ZIP} ${BUILD_CONTEXT}/datadog-agent-latest.amd64.zip
    - cp entrypoint.exe ${BUILD_CONTEXT}/entrypoint.exe
    - pushd ${BUILD_CONTEXT}
    - Expand-Archive datadog-agent-latest.amd64.zip
    - Remove-Item datadog-agent-latest.amd64.zip
    - Get-ChildItem -Path datadog-agent-* | Rename-Item -NewName "Datadog Agent"
    - popd
    - get-childitem ${BUILD_CONTEXT}
    - 'docker run --rm -w C:\mnt -e AWS_NETWORKING=true -e SIGN_WINDOWS_DD_WCS=true
      -e CI_PIPELINE_ID=${CI_PIPELINE_ID} -e CI_PROJECT_NAME=${CI_PROJECT_NAME} -e DOCKER_REGISTRY_LOGIN=${DOCKER_REGISTRY_LOGIN}
      -e DOCKER_REGISTRY_PWD=${DOCKER_REGISTRY_PWD} -v "$(Get-Location):C:\mnt" -v \\.\pipe\docker_engine:\\.\pipe\docker_engine
      486234852809.dkr.ecr.us-east-1.amazonaws.com/ci/datadog-agent-buildimages/windows_${Env:VARIANT}_x64${Env:DATADOG_AGENT_WINBUILDIMAGES_SUFFIX}:${Env:DATADOG_AGENT_WINBUILDIMAGES}
      powershell -C C:\mnt\tools\ci\docker-login.ps1
  
      '
+   - If ($lastExitCode -eq "42") { exit "$lastExitCode" }
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    - powershell -Command "$(Get-Location)\tools\ci\retry.ps1 docker build --no-cache
      --build-arg GENERAL_ARTIFACTS_CACHE_BUCKET_URL=${GENERAL_ARTIFACTS_CACHE_BUCKET_URL}
      ${BUILD_ARG} --pull --file ${BUILD_CONTEXT}/windows/amd64/Dockerfile --tag ${TARGET_TAG}
      ${BUILD_CONTEXT}"
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    - powershell -Command "$(Get-Location)\tools\ci\retry.ps1 docker push ${TARGET_TAG}"
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    - docker rmi ${TARGET_TAG}
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    stage: container_build
    tags:
    - runner:windows-docker
    - windowsversion:1809
    variables:
      AGENT_ZIP: datadog-agent-7*-x86_64.zip
      BUILD_ARG: --build-arg BASE_IMAGE=mcr.microsoft.com/powershell:lts-nanoserver-${VARIANT}
        --build-arg WITH_JMX=${WITH_JMX} --build-arg VARIANT=${VARIANT} --build-arg
        INSTALL_INFO=nano-${VARIANT}
      BUILD_CONTEXT: Dockerfiles/agent
      IMAGE: registry.ddbuild.io/ci/datadog-agent/agent
      TAG_SUFFIX: -7
      VARIANT: 1809
      WITH_JMX: 'false'

docker_build_agent7_windows1809_core

  docker_build_agent7_windows1809_core:
    needs:
    - windows_msi_and_bosh_zip_x64-a7
    - build_windows_container_entrypoint
    rules:
    - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
      when: never
    - when: on_success
    script:
    - $ECR_RELEASE_SUFFIX="$(If ($BUCKET_BRANCH -eq `"nightly`") { `"-nightly`" } elseif
      ($CI_COMMIT_TAG) { `"-release`" } else { `"`" })"
    - $TARGET_TAG="${IMAGE}${ECR_RELEASE_SUFFIX}:v${CI_PIPELINE_ID}-${CI_COMMIT_SHORT_SHA}${TAG_SUFFIX}-win${VARIANT}${SERVERCORE}-amd64"
    - $ErrorActionPreference = "Stop"
    - $_instance_id = (iwr  -UseBasicParsing http://169.254.169.254/latest/meta-data/instance-id).content
      ; Write-Host "Running on instance $($_instance_id)"
    - cp ${OMNIBUS_PACKAGE_DIR}/${AGENT_ZIP} ${BUILD_CONTEXT}/datadog-agent-latest.amd64.zip
    - cp entrypoint.exe ${BUILD_CONTEXT}/entrypoint.exe
    - pushd ${BUILD_CONTEXT}
    - Expand-Archive datadog-agent-latest.amd64.zip
    - Remove-Item datadog-agent-latest.amd64.zip
    - Get-ChildItem -Path datadog-agent-* | Rename-Item -NewName "Datadog Agent"
    - popd
    - get-childitem ${BUILD_CONTEXT}
    - 'docker run --rm -w C:\mnt -e AWS_NETWORKING=true -e SIGN_WINDOWS_DD_WCS=true
      -e CI_PIPELINE_ID=${CI_PIPELINE_ID} -e CI_PROJECT_NAME=${CI_PROJECT_NAME} -e DOCKER_REGISTRY_LOGIN=${DOCKER_REGISTRY_LOGIN}
      -e DOCKER_REGISTRY_PWD=${DOCKER_REGISTRY_PWD} -v "$(Get-Location):C:\mnt" -v \\.\pipe\docker_engine:\\.\pipe\docker_engine
      486234852809.dkr.ecr.us-east-1.amazonaws.com/ci/datadog-agent-buildimages/windows_${Env:VARIANT}_x64${Env:DATADOG_AGENT_WINBUILDIMAGES_SUFFIX}:${Env:DATADOG_AGENT_WINBUILDIMAGES}
      powershell -C C:\mnt\tools\ci\docker-login.ps1
  
      '
+   - If ($lastExitCode -eq "42") { exit "$lastExitCode" }
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    - powershell -Command "$(Get-Location)\tools\ci\retry.ps1 docker build --no-cache
      --build-arg GENERAL_ARTIFACTS_CACHE_BUCKET_URL=${GENERAL_ARTIFACTS_CACHE_BUCKET_URL}
      ${BUILD_ARG} --pull --file ${BUILD_CONTEXT}/windows/amd64/Dockerfile --tag ${TARGET_TAG}
      ${BUILD_CONTEXT}"
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    - powershell -Command "$(Get-Location)\tools\ci\retry.ps1 docker push ${TARGET_TAG}"
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    - docker rmi ${TARGET_TAG}
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    stage: container_build
    tags:
    - runner:windows-docker
    - windowsversion:1809
    variables:
      AGENT_ZIP: datadog-agent-7*-x86_64.zip
      BUILD_ARG: --build-arg BASE_IMAGE=mcr.microsoft.com/powershell:windowsservercore-${VARIANT}
        --build-arg WITH_JMX=${WITH_JMX} --build-arg VARIANT=${VARIANT} --build-arg
        INSTALL_INFO=core-${VARIANT}
      BUILD_CONTEXT: Dockerfiles/agent
      IMAGE: registry.ddbuild.io/ci/datadog-agent/agent
      SERVERCORE: -servercore
      TAG_SUFFIX: -7
      VARIANT: 1809
      WITH_JMX: 'false'

docker_build_agent7_windows1809_core_jmx

  docker_build_agent7_windows1809_core_jmx:
    needs:
    - windows_msi_and_bosh_zip_x64-a7
    - build_windows_container_entrypoint
    rules:
    - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
      when: never
    - when: on_success
    script:
    - $ECR_RELEASE_SUFFIX="$(If ($BUCKET_BRANCH -eq `"nightly`") { `"-nightly`" } elseif
      ($CI_COMMIT_TAG) { `"-release`" } else { `"`" })"
    - $TARGET_TAG="${IMAGE}${ECR_RELEASE_SUFFIX}:v${CI_PIPELINE_ID}-${CI_COMMIT_SHORT_SHA}${TAG_SUFFIX}-win${VARIANT}${SERVERCORE}-amd64"
    - $ErrorActionPreference = "Stop"
    - $_instance_id = (iwr  -UseBasicParsing http://169.254.169.254/latest/meta-data/instance-id).content
      ; Write-Host "Running on instance $($_instance_id)"
    - cp ${OMNIBUS_PACKAGE_DIR}/${AGENT_ZIP} ${BUILD_CONTEXT}/datadog-agent-latest.amd64.zip
    - cp entrypoint.exe ${BUILD_CONTEXT}/entrypoint.exe
    - pushd ${BUILD_CONTEXT}
    - Expand-Archive datadog-agent-latest.amd64.zip
    - Remove-Item datadog-agent-latest.amd64.zip
    - Get-ChildItem -Path datadog-agent-* | Rename-Item -NewName "Datadog Agent"
    - popd
    - get-childitem ${BUILD_CONTEXT}
    - 'docker run --rm -w C:\mnt -e AWS_NETWORKING=true -e SIGN_WINDOWS_DD_WCS=true
      -e CI_PIPELINE_ID=${CI_PIPELINE_ID} -e CI_PROJECT_NAME=${CI_PROJECT_NAME} -e DOCKER_REGISTRY_LOGIN=${DOCKER_REGISTRY_LOGIN}
      -e DOCKER_REGISTRY_PWD=${DOCKER_REGISTRY_PWD} -v "$(Get-Location):C:\mnt" -v \\.\pipe\docker_engine:\\.\pipe\docker_engine
      486234852809.dkr.ecr.us-east-1.amazonaws.com/ci/datadog-agent-buildimages/windows_${Env:VARIANT}_x64${Env:DATADOG_AGENT_WINBUILDIMAGES_SUFFIX}:${Env:DATADOG_AGENT_WINBUILDIMAGES}
      powershell -C C:\mnt\tools\ci\docker-login.ps1
  
      '
+   - If ($lastExitCode -eq "42") { exit "$lastExitCode" }
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    - powershell -Command "$(Get-Location)\tools\ci\retry.ps1 docker build --no-cache
      --build-arg GENERAL_ARTIFACTS_CACHE_BUCKET_URL=${GENERAL_ARTIFACTS_CACHE_BUCKET_URL}
      ${BUILD_ARG} --pull --file ${BUILD_CONTEXT}/windows/amd64/Dockerfile --tag ${TARGET_TAG}
      ${BUILD_CONTEXT}"
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    - powershell -Command "$(Get-Location)\tools\ci\retry.ps1 docker push ${TARGET_TAG}"
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    - docker rmi ${TARGET_TAG}
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    stage: container_build
    tags:
    - runner:windows-docker
    - windowsversion:1809
    variables:
      AGENT_ZIP: datadog-agent-7*-x86_64.zip
      BUILD_ARG: --build-arg BASE_IMAGE=mcr.microsoft.com/powershell:windowsservercore-${VARIANT}
        --build-arg WITH_JMX=${WITH_JMX} --build-arg VARIANT=${VARIANT} --build-arg
        INSTALL_INFO=core-${VARIANT}
      BUILD_CONTEXT: Dockerfiles/agent
      IMAGE: registry.ddbuild.io/ci/datadog-agent/agent
      SERVERCORE: -servercore
      TAG_SUFFIX: -7-jmx
      VARIANT: 1809
      WITH_JMX: 'true'

docker_build_agent7_windows1809_jmx

  docker_build_agent7_windows1809_jmx:
    needs:
    - windows_msi_and_bosh_zip_x64-a7
    - build_windows_container_entrypoint
    rules:
    - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
      when: never
    - when: on_success
    script:
    - $ECR_RELEASE_SUFFIX="$(If ($BUCKET_BRANCH -eq `"nightly`") { `"-nightly`" } elseif
      ($CI_COMMIT_TAG) { `"-release`" } else { `"`" })"
    - $TARGET_TAG="${IMAGE}${ECR_RELEASE_SUFFIX}:v${CI_PIPELINE_ID}-${CI_COMMIT_SHORT_SHA}${TAG_SUFFIX}-win${VARIANT}${SERVERCORE}-amd64"
    - $ErrorActionPreference = "Stop"
    - $_instance_id = (iwr  -UseBasicParsing http://169.254.169.254/latest/meta-data/instance-id).content
      ; Write-Host "Running on instance $($_instance_id)"
    - cp ${OMNIBUS_PACKAGE_DIR}/${AGENT_ZIP} ${BUILD_CONTEXT}/datadog-agent-latest.amd64.zip
    - cp entrypoint.exe ${BUILD_CONTEXT}/entrypoint.exe
    - pushd ${BUILD_CONTEXT}
    - Expand-Archive datadog-agent-latest.amd64.zip
    - Remove-Item datadog-agent-latest.amd64.zip
    - Get-ChildItem -Path datadog-agent-* | Rename-Item -NewName "Datadog Agent"
    - popd
    - get-childitem ${BUILD_CONTEXT}
    - 'docker run --rm -w C:\mnt -e AWS_NETWORKING=true -e SIGN_WINDOWS_DD_WCS=true
      -e CI_PIPELINE_ID=${CI_PIPELINE_ID} -e CI_PROJECT_NAME=${CI_PROJECT_NAME} -e DOCKER_REGISTRY_LOGIN=${DOCKER_REGISTRY_LOGIN}
      -e DOCKER_REGISTRY_PWD=${DOCKER_REGISTRY_PWD} -v "$(Get-Location):C:\mnt" -v \\.\pipe\docker_engine:\\.\pipe\docker_engine
      486234852809.dkr.ecr.us-east-1.amazonaws.com/ci/datadog-agent-buildimages/windows_${Env:VARIANT}_x64${Env:DATADOG_AGENT_WINBUILDIMAGES_SUFFIX}:${Env:DATADOG_AGENT_WINBUILDIMAGES}
      powershell -C C:\mnt\tools\ci\docker-login.ps1
  
      '
+   - If ($lastExitCode -eq "42") { exit "$lastExitCode" }
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    - powershell -Command "$(Get-Location)\tools\ci\retry.ps1 docker build --no-cache
      --build-arg GENERAL_ARTIFACTS_CACHE_BUCKET_URL=${GENERAL_ARTIFACTS_CACHE_BUCKET_URL}
      ${BUILD_ARG} --pull --file ${BUILD_CONTEXT}/windows/amd64/Dockerfile --tag ${TARGET_TAG}
      ${BUILD_CONTEXT}"
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    - powershell -Command "$(Get-Location)\tools\ci\retry.ps1 docker push ${TARGET_TAG}"
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    - docker rmi ${TARGET_TAG}
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    stage: container_build
    tags:
    - runner:windows-docker
    - windowsversion:1809
    variables:
      AGENT_ZIP: datadog-agent-7*-x86_64.zip
      BUILD_ARG: --build-arg BASE_IMAGE=mcr.microsoft.com/powershell:lts-nanoserver-${VARIANT}
        --build-arg WITH_JMX=${WITH_JMX} --build-arg VARIANT=${VARIANT} --build-arg
        INSTALL_INFO=nano-${VARIANT}
      BUILD_CONTEXT: Dockerfiles/agent
      IMAGE: registry.ddbuild.io/ci/datadog-agent/agent
      TAG_SUFFIX: -7-jmx
      VARIANT: 1809
      WITH_JMX: 'true'

docker_build_agent7_windows2022

  docker_build_agent7_windows2022:
    needs:
    - windows_msi_and_bosh_zip_x64-a7
    - build_windows_container_entrypoint
    rules:
    - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
      when: never
    - when: on_success
    script:
    - $ECR_RELEASE_SUFFIX="$(If ($BUCKET_BRANCH -eq `"nightly`") { `"-nightly`" } elseif
      ($CI_COMMIT_TAG) { `"-release`" } else { `"`" })"
    - $TARGET_TAG="${IMAGE}${ECR_RELEASE_SUFFIX}:v${CI_PIPELINE_ID}-${CI_COMMIT_SHORT_SHA}${TAG_SUFFIX}-win${VARIANT}${SERVERCORE}-amd64"
    - $ErrorActionPreference = "Stop"
    - $_instance_id = (iwr  -UseBasicParsing http://169.254.169.254/latest/meta-data/instance-id).content
      ; Write-Host "Running on instance $($_instance_id)"
    - cp ${OMNIBUS_PACKAGE_DIR}/${AGENT_ZIP} ${BUILD_CONTEXT}/datadog-agent-latest.amd64.zip
    - cp entrypoint.exe ${BUILD_CONTEXT}/entrypoint.exe
    - pushd ${BUILD_CONTEXT}
    - Expand-Archive datadog-agent-latest.amd64.zip
    - Remove-Item datadog-agent-latest.amd64.zip
    - Get-ChildItem -Path datadog-agent-* | Rename-Item -NewName "Datadog Agent"
    - popd
    - get-childitem ${BUILD_CONTEXT}
    - 'docker run --rm -w C:\mnt -e AWS_NETWORKING=true -e SIGN_WINDOWS_DD_WCS=true
      -e CI_PIPELINE_ID=${CI_PIPELINE_ID} -e CI_PROJECT_NAME=${CI_PROJECT_NAME} -e DOCKER_REGISTRY_LOGIN=${DOCKER_REGISTRY_LOGIN}
      -e DOCKER_REGISTRY_PWD=${DOCKER_REGISTRY_PWD} -v "$(Get-Location):C:\mnt" -v \\.\pipe\docker_engine:\\.\pipe\docker_engine
      486234852809.dkr.ecr.us-east-1.amazonaws.com/ci/datadog-agent-buildimages/windows_${Env:VARIANT}_x64${Env:DATADOG_AGENT_WINBUILDIMAGES_SUFFIX}:${Env:DATADOG_AGENT_WINBUILDIMAGES}
      powershell -C C:\mnt\tools\ci\docker-login.ps1
  
      '
+   - If ($lastExitCode -eq "42") { exit "$lastExitCode" }
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    - powershell -Command "$(Get-Location)\tools\ci\retry.ps1 docker build --no-cache
      --build-arg GENERAL_ARTIFACTS_CACHE_BUCKET_URL=${GENERAL_ARTIFACTS_CACHE_BUCKET_URL}
      ${BUILD_ARG} --pull --file ${BUILD_CONTEXT}/windows/amd64/Dockerfile --tag ${TARGET_TAG}
      ${BUILD_CONTEXT}"
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    - powershell -Command "$(Get-Location)\tools\ci\retry.ps1 docker push ${TARGET_TAG}"
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    - docker rmi ${TARGET_TAG}
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    stage: container_build
    tags:
    - runner:windows-docker
    - windowsversion:2022
    variables:
      AGENT_ZIP: datadog-agent-7*-x86_64.zip
      BUILD_ARG: --build-arg BASE_IMAGE=mcr.microsoft.com/powershell:lts-nanoserver-${VARIANT}
        --build-arg WITH_JMX=${WITH_JMX} --build-arg VARIANT=${VARIANT} --build-arg
        INSTALL_INFO=nano-${VARIANT}
      BUILD_CONTEXT: Dockerfiles/agent
      IMAGE: registry.ddbuild.io/ci/datadog-agent/agent
      TAG_SUFFIX: '-7'
      VARIANT: ltsc2022
      WITH_JMX: 'false'

docker_build_agent7_windows2022_core

  docker_build_agent7_windows2022_core:
    needs:
    - windows_msi_and_bosh_zip_x64-a7
    - build_windows_container_entrypoint
    rules:
    - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
      when: never
    - when: on_success
    script:
    - $ECR_RELEASE_SUFFIX="$(If ($BUCKET_BRANCH -eq `"nightly`") { `"-nightly`" } elseif
      ($CI_COMMIT_TAG) { `"-release`" } else { `"`" })"
    - $TARGET_TAG="${IMAGE}${ECR_RELEASE_SUFFIX}:v${CI_PIPELINE_ID}-${CI_COMMIT_SHORT_SHA}${TAG_SUFFIX}-win${VARIANT}${SERVERCORE}-amd64"
    - $ErrorActionPreference = "Stop"
    - $_instance_id = (iwr  -UseBasicParsing http://169.254.169.254/latest/meta-data/instance-id).content
      ; Write-Host "Running on instance $($_instance_id)"
    - cp ${OMNIBUS_PACKAGE_DIR}/${AGENT_ZIP} ${BUILD_CONTEXT}/datadog-agent-latest.amd64.zip
    - cp entrypoint.exe ${BUILD_CONTEXT}/entrypoint.exe
    - pushd ${BUILD_CONTEXT}
    - Expand-Archive datadog-agent-latest.amd64.zip
    - Remove-Item datadog-agent-latest.amd64.zip
    - Get-ChildItem -Path datadog-agent-* | Rename-Item -NewName "Datadog Agent"
    - popd
    - get-childitem ${BUILD_CONTEXT}
    - 'docker run --rm -w C:\mnt -e AWS_NETWORKING=true -e SIGN_WINDOWS_DD_WCS=true
      -e CI_PIPELINE_ID=${CI_PIPELINE_ID} -e CI_PROJECT_NAME=${CI_PROJECT_NAME} -e DOCKER_REGISTRY_LOGIN=${DOCKER_REGISTRY_LOGIN}
      -e DOCKER_REGISTRY_PWD=${DOCKER_REGISTRY_PWD} -v "$(Get-Location):C:\mnt" -v \\.\pipe\docker_engine:\\.\pipe\docker_engine
      486234852809.dkr.ecr.us-east-1.amazonaws.com/ci/datadog-agent-buildimages/windows_${Env:VARIANT}_x64${Env:DATADOG_AGENT_WINBUILDIMAGES_SUFFIX}:${Env:DATADOG_AGENT_WINBUILDIMAGES}
      powershell -C C:\mnt\tools\ci\docker-login.ps1
  
      '
+   - If ($lastExitCode -eq "42") { exit "$lastExitCode" }
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    - powershell -Command "$(Get-Location)\tools\ci\retry.ps1 docker build --no-cache
      --build-arg GENERAL_ARTIFACTS_CACHE_BUCKET_URL=${GENERAL_ARTIFACTS_CACHE_BUCKET_URL}
      ${BUILD_ARG} --pull --file ${BUILD_CONTEXT}/windows/amd64/Dockerfile --tag ${TARGET_TAG}
      ${BUILD_CONTEXT}"
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    - powershell -Command "$(Get-Location)\tools\ci\retry.ps1 docker push ${TARGET_TAG}"
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    - docker rmi ${TARGET_TAG}
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    stage: container_build
    tags:
    - runner:windows-docker
    - windowsversion:2022
    variables:
      AGENT_ZIP: datadog-agent-7*-x86_64.zip
      BUILD_ARG: --build-arg BASE_IMAGE=mcr.microsoft.com/powershell:windowsservercore-${VARIANT}
        --build-arg WITH_JMX=${WITH_JMX} --build-arg VARIANT=${VARIANT} --build-arg
        INSTALL_INFO=core-${VARIANT}
      BUILD_CONTEXT: Dockerfiles/agent
      IMAGE: registry.ddbuild.io/ci/datadog-agent/agent
      SERVERCORE: -servercore
      TAG_SUFFIX: '-7'
      VARIANT: ltsc2022
      WITH_JMX: 'false'

docker_build_agent7_windows2022_core_jmx

  docker_build_agent7_windows2022_core_jmx:
    needs:
    - windows_msi_and_bosh_zip_x64-a7
    - build_windows_container_entrypoint
    rules:
    - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
      when: never
    - when: on_success
    script:
    - $ECR_RELEASE_SUFFIX="$(If ($BUCKET_BRANCH -eq `"nightly`") { `"-nightly`" } elseif
      ($CI_COMMIT_TAG) { `"-release`" } else { `"`" })"
    - $TARGET_TAG="${IMAGE}${ECR_RELEASE_SUFFIX}:v${CI_PIPELINE_ID}-${CI_COMMIT_SHORT_SHA}${TAG_SUFFIX}-win${VARIANT}${SERVERCORE}-amd64"
    - $ErrorActionPreference = "Stop"
    - $_instance_id = (iwr  -UseBasicParsing http://169.254.169.254/latest/meta-data/instance-id).content
      ; Write-Host "Running on instance $($_instance_id)"
    - cp ${OMNIBUS_PACKAGE_DIR}/${AGENT_ZIP} ${BUILD_CONTEXT}/datadog-agent-latest.amd64.zip
    - cp entrypoint.exe ${BUILD_CONTEXT}/entrypoint.exe
    - pushd ${BUILD_CONTEXT}
    - Expand-Archive datadog-agent-latest.amd64.zip
    - Remove-Item datadog-agent-latest.amd64.zip
    - Get-ChildItem -Path datadog-agent-* | Rename-Item -NewName "Datadog Agent"
    - popd
    - get-childitem ${BUILD_CONTEXT}
    - 'docker run --rm -w C:\mnt -e AWS_NETWORKING=true -e SIGN_WINDOWS_DD_WCS=true
      -e CI_PIPELINE_ID=${CI_PIPELINE_ID} -e CI_PROJECT_NAME=${CI_PROJECT_NAME} -e DOCKER_REGISTRY_LOGIN=${DOCKER_REGISTRY_LOGIN}
      -e DOCKER_REGISTRY_PWD=${DOCKER_REGISTRY_PWD} -v "$(Get-Location):C:\mnt" -v \\.\pipe\docker_engine:\\.\pipe\docker_engine
      486234852809.dkr.ecr.us-east-1.amazonaws.com/ci/datadog-agent-buildimages/windows_${Env:VARIANT}_x64${Env:DATADOG_AGENT_WINBUILDIMAGES_SUFFIX}:${Env:DATADOG_AGENT_WINBUILDIMAGES}
      powershell -C C:\mnt\tools\ci\docker-login.ps1
  
      '
+   - If ($lastExitCode -eq "42") { exit "$lastExitCode" }
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    - powershell -Command "$(Get-Location)\tools\ci\retry.ps1 docker build --no-cache
      --build-arg GENERAL_ARTIFACTS_CACHE_BUCKET_URL=${GENERAL_ARTIFACTS_CACHE_BUCKET_URL}
      ${BUILD_ARG} --pull --file ${BUILD_CONTEXT}/windows/amd64/Dockerfile --tag ${TARGET_TAG}
      ${BUILD_CONTEXT}"
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    - powershell -Command "$(Get-Location)\tools\ci\retry.ps1 docker push ${TARGET_TAG}"
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    - docker rmi ${TARGET_TAG}
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    stage: container_build
    tags:
    - runner:windows-docker
    - windowsversion:2022
    variables:
      AGENT_ZIP: datadog-agent-7*-x86_64.zip
      BUILD_ARG: --build-arg BASE_IMAGE=mcr.microsoft.com/powershell:windowsservercore-${VARIANT}
        --build-arg WITH_JMX=${WITH_JMX} --build-arg VARIANT=${VARIANT} --build-arg
        INSTALL_INFO=core-${VARIANT}
      BUILD_CONTEXT: Dockerfiles/agent
      IMAGE: registry.ddbuild.io/ci/datadog-agent/agent
      SERVERCORE: -servercore
      TAG_SUFFIX: -7-jmx
      VARIANT: ltsc2022
      WITH_JMX: 'true'

docker_build_agent7_windows2022_jmx

  docker_build_agent7_windows2022_jmx:
    needs:
    - windows_msi_and_bosh_zip_x64-a7
    - build_windows_container_entrypoint
    rules:
    - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
      when: never
    - when: on_success
    script:
    - $ECR_RELEASE_SUFFIX="$(If ($BUCKET_BRANCH -eq `"nightly`") { `"-nightly`" } elseif
      ($CI_COMMIT_TAG) { `"-release`" } else { `"`" })"
    - $TARGET_TAG="${IMAGE}${ECR_RELEASE_SUFFIX}:v${CI_PIPELINE_ID}-${CI_COMMIT_SHORT_SHA}${TAG_SUFFIX}-win${VARIANT}${SERVERCORE}-amd64"
    - $ErrorActionPreference = "Stop"
    - $_instance_id = (iwr  -UseBasicParsing http://169.254.169.254/latest/meta-data/instance-id).content
      ; Write-Host "Running on instance $($_instance_id)"
    - cp ${OMNIBUS_PACKAGE_DIR}/${AGENT_ZIP} ${BUILD_CONTEXT}/datadog-agent-latest.amd64.zip
    - cp entrypoint.exe ${BUILD_CONTEXT}/entrypoint.exe
    - pushd ${BUILD_CONTEXT}
    - Expand-Archive datadog-agent-latest.amd64.zip
    - Remove-Item datadog-agent-latest.amd64.zip
    - Get-ChildItem -Path datadog-agent-* | Rename-Item -NewName "Datadog Agent"
    - popd
    - get-childitem ${BUILD_CONTEXT}
    - 'docker run --rm -w C:\mnt -e AWS_NETWORKING=true -e SIGN_WINDOWS_DD_WCS=true
      -e CI_PIPELINE_ID=${CI_PIPELINE_ID} -e CI_PROJECT_NAME=${CI_PROJECT_NAME} -e DOCKER_REGISTRY_LOGIN=${DOCKER_REGISTRY_LOGIN}
      -e DOCKER_REGISTRY_PWD=${DOCKER_REGISTRY_PWD} -v "$(Get-Location):C:\mnt" -v \\.\pipe\docker_engine:\\.\pipe\docker_engine
      486234852809.dkr.ecr.us-east-1.amazonaws.com/ci/datadog-agent-buildimages/windows_${Env:VARIANT}_x64${Env:DATADOG_AGENT_WINBUILDIMAGES_SUFFIX}:${Env:DATADOG_AGENT_WINBUILDIMAGES}
      powershell -C C:\mnt\tools\ci\docker-login.ps1
  
      '
+   - If ($lastExitCode -eq "42") { exit "$lastExitCode" }
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    - powershell -Command "$(Get-Location)\tools\ci\retry.ps1 docker build --no-cache
      --build-arg GENERAL_ARTIFACTS_CACHE_BUCKET_URL=${GENERAL_ARTIFACTS_CACHE_BUCKET_URL}
      ${BUILD_ARG} --pull --file ${BUILD_CONTEXT}/windows/amd64/Dockerfile --tag ${TARGET_TAG}
      ${BUILD_CONTEXT}"
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    - powershell -Command "$(Get-Location)\tools\ci\retry.ps1 docker push ${TARGET_TAG}"
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    - docker rmi ${TARGET_TAG}
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    stage: container_build
    tags:
    - runner:windows-docker
    - windowsversion:2022
    variables:
      AGENT_ZIP: datadog-agent-7*-x86_64.zip
      BUILD_ARG: --build-arg BASE_IMAGE=mcr.microsoft.com/powershell:lts-nanoserver-${VARIANT}
        --build-arg WITH_JMX=${WITH_JMX} --build-arg VARIANT=${VARIANT} --build-arg
        INSTALL_INFO=nano-${VARIANT}
      BUILD_CONTEXT: Dockerfiles/agent
      IMAGE: registry.ddbuild.io/ci/datadog-agent/agent
      TAG_SUFFIX: -7-jmx
      VARIANT: ltsc2022
      WITH_JMX: 'true'

Changes Summary

Removed	Modified	Added	Renamed
0	11	0	0

ℹ️ Diff available in the job log.

agent-platform-auto-pr · 2024-10-10T18:34:42Z

[Fast Unit Tests Report]

On pipeline 46318419 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

tests_deb-arm64-py3
tests_deb-x64-py3
tests_flavor_dogstatsd_deb-x64
tests_flavor_heroku_deb-x64
tests_flavor_iot_deb-x64
tests_rpm-arm64-py3
tests_rpm-x64-py3
tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

cit-pr-commenter · 2024-10-10T19:38:38Z

Regression Detector

Regression Detector Results

Run ID: c6bcefc2-e2be-4d69-868a-c6af029bee9f Metrics dashboard Target profiles

Baseline: 8938f60
Comparison: 3c243b9

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	idle_all_features	memory utilization	+1.43	[+1.30, +1.55]	1	Logs bounds checks dashboard
➖	tcp_syslog_to_blackhole	ingress throughput	+0.83	[+0.78, +0.89]	1	Logs
➖	otel_to_otel_logs	ingress throughput	+0.67	[-0.13, +1.48]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.31	[-0.18, +0.80]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.30	[-0.43, +1.03]	1	Logs
➖	idle	memory utilization	+0.08	[+0.02, +0.14]	1	Logs bounds checks dashboard
➖	file_to_blackhole_300ms_latency	egress throughput	+0.06	[-0.12, +0.23]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.02	[-0.23, +0.26]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.01	[-0.32, +0.34]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.11, +0.11]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.01, +0.01]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.01	[-0.23, +0.22]	1	Logs
➖	pycheck_lots_of_tags	% cpu utilization	-0.23	[-2.67, +2.21]	1	Logs
➖	basic_py_check	% cpu utilization	-0.62	[-3.28, +2.05]	1	Logs
➖	file_tree	memory utilization	-0.65	[-0.79, -0.50]	1	Logs

Bounds Checks

perf	experiment	bounds_check_name	replicates_passed
❌	file_to_blackhole_1000ms_latency	memory_usage	0/10
❌	file_to_blackhole_300ms_latency	memory_usage	0/10
❌	file_to_blackhole_500ms_latency	memory_usage	0/10
❌	idle	memory_usage	6/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	idle_all_features	memory_usage	10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

fix(fetch_secret): Transfer the exit code in windows context

32473cf

Currently when facing an `Unable to locate` credential issue on windows we are not using the `retry:exit_codes`. To do so we need to transfer the $lastExitCode up to the Gitlab script

chouetz added changelog/no-changelog qa/no-code-change Skip QA week as there is no code change in Agent code labels Oct 10, 2024

chouetz added 2 commits October 10, 2024 20:13

Transfer the lastExitCode to Gitlab

cb9e728

add quotes

3c243b9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(fetch_secret): Transfer the exit code in windows context #30031

fix(fetch_secret): Transfer the exit code in windows context #30031

chouetz commented Oct 10, 2024

agent-platform-auto-pr bot commented Oct 10, 2024

Modified Jobs

agent-platform-auto-pr bot commented Oct 10, 2024

cit-pr-commenter bot commented Oct 10, 2024

Fine details of change detection per experiment

Explanation

fix(fetch_secret): Transfer the exit code in windows context #30031

Are you sure you want to change the base?

fix(fetch_secret): Transfer the exit code in windows context #30031

Conversation

chouetz commented Oct 10, 2024

What does this PR do?

Motivation

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

agent-platform-auto-pr bot commented Oct 10, 2024

Gitlab CI Configuration Changes

Modified Jobs

Changes Summary

agent-platform-auto-pr bot commented Oct 10, 2024

cit-pr-commenter bot commented Oct 10, 2024

Regression Detector

Regression Detector Results

No significant changes in experiment optimization goals

Fine details of change detection per experiment

Bounds Checks

Explanation