Improve stability of the CAPI metadata tags collection feature #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cf restart scenarios
…gs from being overriden
NouemanKHAL
added
the
changelog/Fixed
This reverts commit b820a5b.
sarah-witt
reviewed
Dec 19, 2022
sarah-witt
reviewed
Dec 19, 2022
Comment on lines
+49
to
+53
| # verify that check_datadog exited successfully | ||
| if [ ${exit_code} -ne 0 ]; then | ||
| log_error "could not find agent, aborting update script!" | ||
| exit ${exit_code} | ||
| fi |
There was a problem hiding this comment.
In this case, I think we should still try running the update script. Maybe the agent was killed in between runs of the script. But if we don't do this, then we should confirm the trace agent isn't running before exiting since we don't want to be in a state with the trace agent running but not the agent.
…ction file, cleanup code, remove ruby scripts
… the lockfile to matcht the script name
sarah-witt
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
SUPPRESS_DD_AGENT_OUTPUTbehaviour and logs redirection.ImportError: No module named siteon thecreate_logs_configpython script by switching to Ruby.update_tags.rbscript.update_agent_config.shscript.Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.