[dogstatsd] Add statsd_constant_tags kwarg to datadog.initialize()
#494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per the documentation here https://docs.datadoghq.com/developers/dogstatsd/?tab=python#client-instantiation-parameters It seems like you should be able to pass constant tags to the default statsd via the datadog initialize method.
jirikuncar
suggested changes
Dec 12, 2019
There was a problem hiding this comment.
@kainswor thank you for the improvement. Can you also add the new parameter to the docstring?
everytime I use the github editor it bites me lol
jd
approved these changes
Dec 13, 2019
jirikuncar
approved these changes
Dec 13, 2019
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Thanks for working on this @kainswor |
zippolyte
changed the title
statsd_constant_tags kwarg to datadog.initialize()
zippolyte
changed the title
statsd_constant_tags kwarg to datadog.initialize()statsd_constant_tags kwarg to datadog.initialize()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the documentation here https://docs.datadoghq.com/developers/dogstatsd/?tab=python#client-instantiation-parameters
It seems like you should be able to pass constant tags to the default statsd via the datadog initialize method. This just adds it and merges the list already in the default datadog.dogstatsd.statsd class similar to how the other statsd_* kwargs are handled