Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typescript errors #517

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Fix typescript errors #517

merged 1 commit into from
Aug 3, 2023

Conversation

louiszawadzki
Copy link
Contributor

What does this PR do?

Typescript checks were broken after PR #515, which prevents from building packages for release.
This fixes the issue.

I've added a step to run typescript checks in the CI now.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@louiszawadzki louiszawadzki requested a review from a team as a code owner August 2, 2023 13:53
@louiszawadzki louiszawadzki merged commit 1775de5 into develop Aug 3, 2023
3 checks passed
@louiszawadzki louiszawadzki deleted the louiszawadzki/fix-typescript branch August 3, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plousada plousada plousada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louiszawadzki @plousada