Fix webview telemetry for new architecture apps #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xnm
approved these changes
Oct 25, 2023
louiszawadzki
added a commit
that referenced
this pull request
Oct 30, 2023
…chitecture Fix webview telemetry for new architecture apps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Uses the new TurboModule for calling telemetryError in the Webview support package.
We were trying to access
NativeModules.DdSdkbefore, which would not be defined for the new architecture. The impact would be that in that case we would not calltelemetryError, so not a big impact.This PR makes sure we call the correct module in any case.
Test for this feature will come in #541 when we run every package in isolation.
Review checklist (to be filled by reviewers)