[RUM-5393] Tracking non-fatal ANRs and app hangs #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marco-saia-datadog
force-pushed
the
marcosaia/RUM-5393/app-hangs-and-anrs
branch
2 times, most recently
from
a25759b
to
3b7e089
Compare
marco-saia-datadog
force-pushed
the
marcosaia/RUM-5393/app-hangs-and-anrs
branch
from
3b7e089
to
db70e4d
Compare
fuzzybinary
requested changes
Aug 6, 2024
| @@ -267,6 +267,30 @@ export class DdSdkReactNativeConfiguration { | |||
| */ | |||
| public bundleLogsWithTraces: boolean = DEFAULTS.bundleLogsWithTraces; | |||
|
|
|||
| /** | |||
| * Enables tracking of non-fatal ANRs on Android. | |||
There was a problem hiding this comment.
I'm wondering if we can call out these platform specific features in a better and more consistent way? Basically using the same language in both in the same place so that it's not missed...
There was a problem hiding this comment.
I was wondering the same thing. We could align on some good naming for these parameters, do you have any ideas?
There was a problem hiding this comment.
Maybe "This option is specific to Platform" as the second line and remove any other mention of platforms?
|
Looks good, I would just cleanup that one swift |
fuzzybinary
reviewed
Aug 7, 2024
marco-saia-datadog
force-pushed
the
marcosaia/RUM-5393/app-hangs-and-anrs
branch
from
db70e4d
to
f22e070
Compare
marco-saia-datadog
force-pushed
the
marcosaia/RUM-5393/app-hangs-and-anrs
branch
from
f22e070
to
fc19da2
Compare
fuzzybinary
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds tracking for non-fatal ANRs on Android and app hangs on iOS.
Review checklist (to be filled by reviewers)