Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUM-5918] Update native Datadog SDKs #718

Merged
merged 13 commits into from
Oct 10, 2024

Conversation

marco-saia-datadog
Copy link
Contributor

@marco-saia-datadog marco-saia-datadog commented Aug 23, 2024

What does this PR do?

Bumps native Datadog SDKs versions:

  • iOS 2.14.1 -> 2.18.0
  • Android 2.11.0 -> 2.14.0

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@marco-saia-datadog marco-saia-datadog force-pushed the marcosaia/RUM-5918/update-dd-sdks branch 4 times, most recently from 678da3d to 02bc6b4 Compare August 26, 2024 14:20
* iOS 2.14.1 -> 2.16.0
* Android 2.11.0 -> 2.12.1
@marco-saia-datadog marco-saia-datadog marked this pull request as ready for review September 2, 2024 07:49
@marco-saia-datadog marco-saia-datadog requested a review from a team as a code owner September 2, 2024 07:49
@fuzzybinary
Copy link

You might want to wait on this for 2.13.1.

@@ -3,11 +3,11 @@
buildscript {
ext {
buildToolsVersion = "34.0.0"
minSdkVersion = 21
minSdkVersion = 23
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we raise min SDK? Is it because of the RN version used in this sample app?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I finally got back to this again. Sorry for the long wait. Yes, a bump of the version was required for new architecture in the example app.

packages/core/android/build.gradle Outdated Show resolved Hide resolved
@marco-saia-datadog
Copy link
Contributor Author

New versions:

  • iOS 2.14.1 -> 2.18.0
  • Android 2.11.0 -> 2.14.0

@marco-saia-datadog marco-saia-datadog requested a review from a team October 8, 2024 07:59
example/android/build.gradle Show resolved Hide resolved
internal object DdSdkSynthetics {
var testId: String? = null
var resultId: String? = null
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
}

packages/core/android/gradle.properties Show resolved Hide resolved
@compwron
Copy link

My team is excited for this :)

@marco-saia-datadog marco-saia-datadog merged commit 3f7d633 into develop Oct 10, 2024
6 checks passed
@marco-saia-datadog marco-saia-datadog deleted the marcosaia/RUM-5918/update-dd-sdks branch October 10, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants