Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump debase-ruby_core_source dependency to 3.2.3 #3284

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

ivoanjo
Copy link
Member

@ivoanjo ivoanjo commented Nov 27, 2023

What does this PR do?

This PR bumps our dependency on debase-ruby_core_source to version 3.2.3. This version is needed to support profiling Ruby 3.3.0-preview3.

Motivation:

Support profiling on Ruby 3.3.0-preview3.

Additional Notes:

I've updated the appraisal gemfiles as well.

This PR unblocks #3259.

How to test the change?

Validate that CI is green.

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

**What does this PR do?**

This PR bumps our dependency on `debase-ruby_core_source` to version
3.2.3. This version is needed to support profiling Ruby 3.3.0-preview3.

**Motivation:**

Support profiling on Ruby 3.3.0-preview3.

**Additional Notes:**

I've updated the appraisal gemfiles as well.

This PR unblocks #3259.

**How to test the change?**

Validate that CI is green.
As documented in `extconf.rb`, this flag can cause compilation failures
because mkmf picks it up and uses it when calling `have_header`.

For now I decided to disable it on 3.3, for fear it'll happen in
3.3.0-stable as well. We can revisit this later, and anyway for our
own we get a lot of cover from the fact that all other Ruby versions
still compile with this option enabled.
@ivoanjo ivoanjo requested a review from a team as a code owner November 27, 2023 11:43
@github-actions github-actions bot added the profiling Involves Datadog profiling label Nov 27, 2023
@ivoanjo ivoanjo merged commit adbe53a into master Nov 27, 2023
215 of 216 checks passed
@ivoanjo ivoanjo deleted the ivoanjo/bump-debase-ruby-core-source-3_2_3 branch November 27, 2023 12:01
@github-actions github-actions bot added this to the 1.18.0 milestone Nov 27, 2023
@TonyCTHsu TonyCTHsu mentioned this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
profiling Involves Datadog profiling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants