Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rumble feature for bluetooth devices #108

Merged
merged 1 commit into from
Feb 3, 2019

Conversation

quark-zju
Copy link
Contributor

When rumble_obj.t >= 0, SendRumble should be frequently called to make
Rumbling actually work.

When rumble_obj.t >= 0, SendRumble should be frequently called to make
Rumbling actually work.
@Davidobot
Copy link
Owner

Thank you, that actually makes more sense than what I was trying to do with sending the data every 1000f / timing).

I'll merge this request, but will experiment with perhaps 2 parts of the if-statement -- if (rumble.t > 0 and BT) or USB, send all the time; if (not rumble.t > 0 and BT), send every 5 second or so.

@Davidobot Davidobot merged commit 3eddf93 into Davidobot:master Feb 3, 2019
d3xMachina pushed a commit to d3xMachina/BetterJoy that referenced this pull request Nov 19, 2021
Fix Rumble feature for bluetooth devices
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants