Modify other Dockerfiles with 2stage and conda-pack improvements #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an extension of #145, where the
Dockerfile_reconsurfwas improved with multi-stage builds, integrating conda-pack, and installing packages using yaml files.Here, the other Dockerfiles are modified to include the same changes.
The sizes of images produced by each Dockerfile are now as follows:
Follow-up Items
(1) The base image for the GPU-supporting images may be switched from
nvidia/cuda:11.1-cudnn8-runtime-ubuntu20.04toubuntu20.04soon, since a global CUDA+CuDNN installation may be unnecessary for pytorch installed with cudatoolkit. With this change, these images will shrink considerably, and all images will share the same base image.(2) Once (1) is included, the Dockerfiles are quite similar except for the input yaml files and whether FreeSurfer is installed or not. They could be reduced to a single file with docker build arguments, such as
WITH_CUDAandWITH_FS.