Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mixpanel] Add time_event, people.union, and typedef for init config param #20342

Merged
merged 2 commits into from
Oct 11, 2017

Conversation

pnw
Copy link
Contributor

@pnw pnw commented Oct 6, 2017

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

@dt-bot
Copy link
Member

dt-bot commented Oct 6, 2017

types/mixpanel/index.d.ts

to author (@hjellek). Could you review this PR?
👍 or 👎?

Checklist

  • pass the Travis CI test?

@pnw
Copy link
Contributor Author

pnw commented Oct 6, 2017

This resolves: #19642

@typescript-bot
Copy link
Contributor

typescript-bot commented Oct 11, 2017

Approved by a listed owner. PR ready to merge pending express review by a maintainer.

@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label Oct 11, 2017
@hjellek
Copy link

hjellek commented Oct 11, 2017

Sorry for late answer, the change seems okay.

👍

@typescript-bot typescript-bot moved this from Merge: YSYL to Merge: Express in Pull Request Triage Backlog Oct 11, 2017
@typescript-bot typescript-bot added Author Approved and removed Unmerged The author did not merge the PR when it was ready. labels Oct 11, 2017
@weswigham weswigham merged commit 6b3463e into DefinitelyTyped:master Oct 11, 2017
@typescript-bot typescript-bot removed this from Merge: Express in Pull Request Triage Backlog Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants