Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meteor] EJSONableCustomType shloud have clone and equal method optional #20494

Merged
merged 1 commit into from
Oct 11, 2017

Conversation

uiii
Copy link
Contributor

@uiii uiii commented Oct 11, 2017

According to meteor docs a custom type registered to EJSON is allowed to omit the clone and equals methods. See https://docs.meteor.com/api/ejson.html#EJSON-addType

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: https://docs.meteor.com/api/ejson.html#EJSON-addType
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

…ptional

According to meteor docs a custom type registered to EJSON is allowed to omit the `clone` and `equals` methods. See https://docs.meteor.com/api/ejson.html#EJSON-addType
@dt-bot
Copy link
Member

dt-bot commented Oct 11, 2017

types/meteor/ejson.d.ts

to authors (@barbatus @fullflavedave @orefalo @dagatsoin @birkskyum @ardatan @stefanholzapfel). Could you review this PR?
👍 or 👎?

@ardatan
Copy link
Contributor

ardatan commented Oct 11, 2017

👍 lgtm

@typescript-bot
Copy link
Contributor

Approved by a listed owner. PR ready to merge pending express review by a maintainer.

@weswigham weswigham merged commit 7031c86 into DefinitelyTyped:master Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants