Skip to content

Commit

Permalink
[CWR] Improve BUILD file readability
Browse files Browse the repository at this point in the history
This CL improves the readability of the
`//chromecast/cast_core/BUILD.gn` file.

Change-Id: Ia1629ff22faae95b166c43f63f0d22d136701734
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3140102
Reviewed-by: Sean Topping <seantopping@chromium.org>
Commit-Queue: Ryan Keane <rwkeane@google.com>
Cr-Commit-Position: refs/heads/main@{#920416}
  • Loading branch information
Ryan Keane authored and Chromium LUCI CQ committed Sep 10, 2021
1 parent 001c22b commit 01d7115
Showing 1 changed file with 26 additions and 25 deletions.
51 changes: 26 additions & 25 deletions chromecast/cast_core/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,27 @@

import("//chromecast/chromecast.gni")

group("cast_core") {
deps = [
":browser",
":grpc_webui",
":message_port",
":metrics_recorder",
":renderer",
":runtime_service",
":streaming_receiver_session_client",
":url_rewrite",
]

if (is_linux) {
deps += [ ":core_service" ]
}

if (enable_cast_media_runtime) {
deps += [ ":cast_runtime_content_client_factories" ]
}
}

cast_source_set("grpc_support") {
sources = [
"grpc_method.cc",
Expand Down Expand Up @@ -136,7 +157,7 @@ cast_source_set("grpc_webui") {
}

if (is_linux) {
cast_source_set("core_runtime_bindings") {
cast_source_set("core_service_bindings") {
sources = [
"bindings_manager_web_runtime.cc",
"bindings_manager_web_runtime.h",
Expand All @@ -157,7 +178,7 @@ if (is_linux) {
deps = [ "//chromecast/bindings:bindings_manager_cast" ]
}

cast_source_set("core_runtime") {
cast_source_set("core_service") {
sources = [
"runtime_application_service.cc",
"runtime_application_service.h",
Expand All @@ -183,7 +204,7 @@ if (is_linux) {
]

deps = [
":core_runtime_bindings",
":core_service_bindings",
":url_rewrite",
"//chromecast/browser:browser_base",
"//content/public/browser",
Expand Down Expand Up @@ -278,7 +299,7 @@ cast_source_set("runtime_service") {
]

public_deps += [
":core_runtime",
":core_service",
":metrics_recorder",
]

Expand Down Expand Up @@ -312,6 +333,7 @@ if (enable_cast_media_runtime) {
}
}

# When built for use with Cast Core, enble_cast_media_runtime must be true.
cast_executable("core_runtime_simple") {
sources = [ "cast_runtime_main.cc" ]

Expand Down Expand Up @@ -362,27 +384,6 @@ cast_source_set("cast_core_test_utils") {
]
}

group("cast_core") {
deps = [
":browser",
":grpc_webui",
":message_port",
":metrics_recorder",
":renderer",
":runtime_service",
":streaming_receiver_session_client",
":url_rewrite",
]

if (is_linux) {
deps += [ ":core_runtime" ]
}

if (enable_cast_media_runtime) {
deps += [ ":cast_runtime_content_client_factories" ]
}
}

# TODO(b/194439829): Upstream additional metrics unit tests.
test("cast_cast_core_unittests") {
sources = [
Expand Down

0 comments on commit 01d7115

Please sign in to comment.