Skip to content

Commit

Permalink
Revert "[Files F2] Turn on NewDirectory flag temporarily"
Browse files Browse the repository at this point in the history
This reverts commit f63f3ba.

Reason for revert: suspect for errors starting in https://ci.chromium.org/ui/p/chrome/builders/ci/chromeos-eve-chrome/27269/

Failed to verify sharing results
at go.chromium.org/tast-tests/cros/local/bundles/cros/crostini.ShareDrive (share_drive.go:115)
at go.chromium.org/tast/core/internal/planner.runTestWithConfig.func4.1 (run.go:846)
at go.chromium.org/tast/core/internal/usercode.SafeCall.func2 (usercode.go:112)
at runtime.goexit (asm_amd64.s:1598)
failed to verify shared folders list, got [], want [Google Drive › My Drive]
at go.chromium.org/tast-tests/cros/local/bundles/cros/crostini.checkDriveResults (share_drive.go:221)

Original change's description:
> [Files F2] Turn on NewDirectory flag temporarily
>
> Check how the bots work with the new directory tree, will turn it
> off before M121 branching.
>
> Bug: b:272125628
> Change-Id: Ie286cb3acff49077f19662383418dfb7f9f04b03
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5048411
> Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
> Commit-Queue: Wenbo Jie <wenbojie@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1227784}

Bug: b:272125628
Change-Id: I54aca71def8b88ba8286a9b815a70911ae8cc24e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5051471
Commit-Queue: Trent Apted <tapted@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1227845}
  • Loading branch information
tapted authored and Chromium LUCI CQ committed Nov 22, 2023
1 parent a549f02 commit 0225392
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion ash/constants/ash_features.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1149,7 +1149,7 @@ BASE_FEATURE(kFilesConflictDialog,
// Enables new directory tree implementation in files.
BASE_FEATURE(kFilesNewDirectoryTree,
"FilesNewDirectoryTree",
base::FEATURE_ENABLED_BY_DEFAULT);
base::FEATURE_DISABLED_BY_DEFAULT);

// Enables local image search by query in the Files app.
BASE_FEATURE(kFilesLocalImageSearch,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -605,7 +605,6 @@ export async function testCommandsForNonInteractiveVolumeAndNoEntries(done) {
const event = {
canExecute: true,
target: {
classList: {contains: () => false},
parentElement: {
contextElement: null,
},
Expand Down

0 comments on commit 0225392

Please sign in to comment.