forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
While testing git "cl presubmit --all" I saw a number of include-order errors. With the new --files option to "git cl presubmit" these can most easily be reproduced with: git cl presubmit --force --files=ui\views\*.h;ui\views\*.cc A simplified version of the report is: ui\views\controls\native\native_view_host_test_base.cc:8: Found C++ system header after other header. ui\views\controls\textfield\textfield_unittest.h:11: Found C++ system header after other header. ui\views\examples\examples_skia_gold_pixel_diff.cc:22: Add #include <string> for string ui\views\examples\examples_skia_gold_pixel_diff.h:28: Add #include <string> for string ui\views\examples\examples_window.cc:8: Found C++ system header after other header. ui\views\test\combobox_test_api.cc:8: Found C system header after other header. ui\views\test\focus_manager_test.h:11: Found C++ system header after other header. ui\views_content_client\views_content_browser_client.cc:23: Add #include <utility> for move ui\views_content_client\views_content_client_main_parts_aura.cc:18: Add #include <utility> for move Many (but not all) of these are from the insertion of the include of "base/memory/raw_ptr.h" as part of the rewrite in crrev.com/c/3305132. Some of those includes were inserted in the wrong place. With this change the "git cl presubmit" invocation above is now clean. Bug: 1309977 Change-Id: I0e2e5c957044209c946c8ad94d201c9cbeafbbfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3566748 Reviewed-by: Mike Wasserman <msw@chromium.org> Reviewed-by: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/main@{#988763}
- Loading branch information
1 parent
c3962c4
commit 0279b9e
Showing
8 changed files
with
11 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters