Skip to content

Commit

Permalink
Remove leftover <vector> includes in base/
Browse files Browse the repository at this point in the history
This is among the most costful includes for the Chromium build.
https://commondatastorage.googleapis.com/chromium-browser-clang/include-analysis.html

Bug: 1233968
Change-Id: I9a4bcd8fe454daacaa0e022be9ea6643eeead250
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3059651
Auto-Submit: Victor Vianna <victorvianna@google.com>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Victor Vianna <victorvianna@google.com>
Cr-Commit-Position: refs/heads/master@{#908903}
  • Loading branch information
Victor Hugo Vianna Silva authored and Chromium LUCI CQ committed Aug 5, 2021
1 parent 3c7559d commit 05f1454
Show file tree
Hide file tree
Showing 21 changed files with 7 additions and 17 deletions.
1 change: 0 additions & 1 deletion base/containers/flat_set_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
#include "base/containers/flat_set.h"

#include <string>
#include <vector>

#include "base/memory/ptr_util.h"
#include "base/test/move_only_int.h"
Expand Down
1 change: 0 additions & 1 deletion base/debug/debugger_posix.cc
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#include <unistd.h>

#include <memory>
#include <vector>

#include "base/check_op.h"
#include "base/clang_profiling_buildflags.h"
Expand Down
1 change: 1 addition & 0 deletions base/files/file_util.cc
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
#include <fstream>
#include <limits>
#include <memory>
#include <vector>

#include "base/check_op.h"
#include "base/files/file_enumerator.h"
Expand Down
1 change: 0 additions & 1 deletion base/files/file_util.h
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#include <limits>
#include <set>
#include <string>
#include <vector>

#include "base/base_export.h"
#include "base/callback_forward.h"
Expand Down
1 change: 0 additions & 1 deletion base/i18n/icu_string_conversions.cc
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
#include <stdint.h>

#include <memory>
#include <vector>

#include "base/check.h"
#include "base/notreached.h"
Expand Down
1 change: 0 additions & 1 deletion base/json/json_reader.cc
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
#include "base/json/json_reader.h"

#include <utility>
#include <vector>

#include "base/json/json_parser.h"
#include "third_party/abseil-cpp/absl/types/optional.h"
Expand Down
1 change: 0 additions & 1 deletion base/mac/foundation_util.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
#include <CoreFoundation/CoreFoundation.h>

#include <string>
#include <vector>

#include "base/base_export.h"
#include "base/logging.h"
Expand Down
2 changes: 2 additions & 0 deletions base/mac/foundation_util.mm
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
#include <stdlib.h>
#include <string.h>

#include <vector>

#include "base/cxx17_backports.h"
#include "base/files/file_path.h"
#include "base/logging.h"
Expand Down
1 change: 0 additions & 1 deletion base/metrics/histogram_base.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
#include <atomic>
#include <memory>
#include <string>
#include <vector>

#include "base/atomicops.h"
#include "base/base_export.h"
Expand Down
1 change: 0 additions & 1 deletion base/profiler/suspendable_thread_delegate.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
#ifndef BASE_PROFILER_SUSPENDABLE_THREAD_DELEGATE_H_
#define BASE_PROFILER_SUSPENDABLE_THREAD_DELEGATE_H_

#include <vector>

#include "base/base_export.h"
#include "base/profiler/register_context.h"
Expand Down
2 changes: 2 additions & 0 deletions base/profiler/suspendable_thread_delegate_mac.cc
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
#include <mach/thread_act.h>
#include <pthread.h>

#include <vector>

#include "base/check.h"
#include "base/mac/mach_logging.h"
#include "base/profiler/profile_builder.h"
Expand Down
2 changes: 2 additions & 0 deletions base/profiler/suspendable_thread_delegate_win.cc
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
#include <windows.h>
#include <winternl.h>

#include <vector>

#include "base/check.h"
#include "base/debug/alias.h"
#include "base/profiler/native_unwinder_win.h"
Expand Down
1 change: 0 additions & 1 deletion base/supports_user_data_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

#include "base/supports_user_data.h"

#include <vector>

#include "base/memory/ptr_util.h"
#include "testing/gtest/include/gtest/gtest.h"
Expand Down
1 change: 0 additions & 1 deletion base/task/thread_pool/task_tracker.cc
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
#include <atomic>
#include <string>
#include <utility>
#include <vector>

#include "base/base_switches.h"
#include "base/callback.h"
Expand Down
1 change: 0 additions & 1 deletion base/task/thread_pool/thread_pool_impl.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
#define BASE_TASK_THREAD_POOL_THREAD_POOL_IMPL_H_

#include <memory>
#include <vector>

#include "base/base_export.h"
#include "base/callback.h"
Expand Down
1 change: 0 additions & 1 deletion base/task/thread_pool/thread_pool_instance.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
#define BASE_TASK_THREAD_POOL_THREAD_POOL_INSTANCE_H_

#include <memory>
#include <vector>

#include "base/base_export.h"
#include "base/callback.h"
Expand Down
1 change: 0 additions & 1 deletion base/test/launcher/test_launcher_test_utils.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
#include <stddef.h>

#include <string>
#include <vector>

#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/abseil-cpp/absl/types/optional.h"
Expand Down
1 change: 0 additions & 1 deletion base/test/test_file_util_win.cc
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
#include <windows.h>

#include <memory>
#include <vector>

#include "base/check_op.h"
#include "base/files/file_path.h"
Expand Down
1 change: 0 additions & 1 deletion base/trace_event/trace_event_impl.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@

#include <memory>
#include <string>
#include <vector>

#include "base/base_export.h"
#include "base/callback.h"
Expand Down
1 change: 0 additions & 1 deletion base/win/pe_image_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

// This file contains unit tests for PEImage.
#include <algorithm>
#include <vector>

#include "base/files/file_path.h"
#include "base/path_service.h"
Expand Down
1 change: 0 additions & 1 deletion base/win/registry_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
#include <stdint.h>

#include <cstring>
#include <vector>

#include "base/bind.h"
#include "base/compiler_specific.h"
Expand Down

0 comments on commit 05f1454

Please sign in to comment.