Skip to content

Commit

Permalink
Remove references to phajdan.jr
Browse files Browse the repository at this point in the history
Bug: 783662
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If14081b9b17a3502435d2f2c4fcccfbbe51ae813
Reviewed-on: https://chromium-review.googlesource.com/763447
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515954}
  • Loading branch information
Paweł Hajdan, Jr committed Nov 13, 2017
1 parent f303b12 commit 064792e
Show file tree
Hide file tree
Showing 25 changed files with 0 additions and 66 deletions.
2 changes: 0 additions & 2 deletions OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,11 @@ per-file .vpython=dpranke@chromium.org
per-file .vpython=iannucci@chromium.org
per-file .vpython=jbudorick@chromium.org
per-file .vpython=nednguyen@chromium.org
per-file .vpython=phajdan.jr@chromium.org
per-file AUTHORS=*
per-file BUILD.gn=file://build/OWNERS
per-file codereview.settings=agable@chromium.org
per-file DEPS=*
per-file PRESUBMIT*.py=dcheng@chromium.org
per-file PRESUBMIT*.py=jochen@chromium.org
per-file PRESUBMIT*.py=phajdan.jr@chromium.org
per-file README.md=*
per-file WATCHLISTS=*
4 changes: 0 additions & 4 deletions WATCHLISTS
Original file line number Diff line number Diff line change
Expand Up @@ -855,9 +855,6 @@
'filesapp_ui': {
'filepath': 'ui/file_manager'
},
'ftp': {
'filepath': 'ftp',
},
'fuchsia': {
'filepath': 'fuchsia',
},
Expand Down Expand Up @@ -2013,7 +2010,6 @@
'oka+watch@chromium.org',
'yamaguchi+watch@chromium.org'],
'filesapp_ui': ['mtomasz+watch@chromium.org'],
'ftp': ['phajdan.jr@chromium.org'],
'fuchsia': ['sergeyu@chromium.org', 'wez@chromium.org'],
'fuzzing': ['fuzzing@chromium.org'],
'gamepad': ['cco3+watch@chromium.org',
Expand Down
2 changes: 0 additions & 2 deletions base/test/OWNERS
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
phajdan.jr@chromium.org

per-file *task_scheduler*=file://base/task_scheduler/OWNERS

# Metrics-related test utilties:
Expand Down
1 change: 0 additions & 1 deletion build/linux/OWNERS
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
mmoss@chromium.org
phajdan.jr@chromium.org
thestig@chromium.org
thomasanderson@chromium.org
1 change: 0 additions & 1 deletion chrome/installer/linux/OWNERS
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
set noparent
mmoss@chromium.org
phajdan.jr@chromium.org
thestig@chromium.org
thomasanderson@chromium.org
1 change: 0 additions & 1 deletion chrome/test/OWNERS
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
phajdan.jr@chromium.org
sky@chromium.org

# If you're doing structural changes get a review from one of the OWNERS.
Expand Down
2 changes: 0 additions & 2 deletions chromecast/browser/test/OWNERS

This file was deleted.

1 change: 0 additions & 1 deletion components/keyed_service/OWNERS
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
erg@chromium.org
phajdan.jr@chromium.org
1 change: 0 additions & 1 deletion content/public/test/OWNERS
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
phajdan.jr@chromium.org
sky@chromium.org

# For WebRTC files.
Expand Down
1 change: 0 additions & 1 deletion content/test/OWNERS
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
phajdan.jr@chromium.org
sky@chromium.org

# For WebRTC files.
Expand Down
33 changes: 0 additions & 33 deletions docs/adding_to_third_party.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,6 @@ Run the following scripts:
* `src/tools/licenses.py scan` - This will complain about incomplete or missing
data for third_party checkins. We use 'licenses.py credits' to generate the
about:credits page in Google Chrome builds.
* `src/tools/checklicenses/checklicenses.py` - See below for info on how to
handle possible failures.

See the ["Odds n' Ends"](adding_to_third_party.md#Odds-n_Ends) Section below if
you run into any failures running these.

If the library will never be shipped as a part of Chrome (e.g. build-time tools,
testing tools), make sure to set "License File" as "NOT_SHIPPED" so that the
Expand Down Expand Up @@ -155,31 +150,3 @@ ticket](https://bugs.chromium.org/p/chromium/issues/entry?template=Infra-Git)
for infra and ask the infra team what needs to be done. Note that you'll need
unlimited quota for at least two role accounts. See the quota status of
`boringssl` as an example.

## Odds n' Ends

### Handling `licenses_check (checklicenses.py)` failures

This is needed for [Issue
28291](http://code.google.com/p/chromium/issues/detail?id=28291): Pass the
Ubuntu license check script:

__If the failure looks like ... ... the right action is to ... __

* 'filename' has non-whitelisted license 'UNKNOWN'
* Ideally make the licensecheck.pl script recognize the license of that
file. Often this requires __adding a license header__. Does it have
license header? If it's third party code, ask the upstream project to make
sure all their files have license headers. If the license header is there
but is not recognized, we should try to patch licensecheck.pl. If in
doubt please contact phajdan.jr@chromium.org
* 'filename' has non-whitelisted license 'X' and X is BSD-compatible
* Add the license X to WHITELISTED_LICENSES in checklicenses.py . Make sure
to respect the OWNERS of that file. You must get an approval before
landing. CLs violating this requirement may be reverted.
* 'filename' has non-whitelisted license 'X' and X is not BSD-compatible (i.e.
GPL)
* Do you really need to add those files? Chromium is BSD-licensed so the
resulting binaries can't use GPL code. Ideally we just shouldn't have
those files at all in the tree. If in doubt, please ask mal@chromium.org

1 change: 0 additions & 1 deletion infra/OWNERS
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
iannucci@chromium.org
nodir@chromium.org
phajdan.jr@chromium.org
sergiyb@chromium.org
dpranke@chromium.org

Expand Down
1 change: 0 additions & 1 deletion infra/config/OWNERS
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
phajdan.jr@chromium.org
sergiyb@chromium.org
smut@google.com
tandrii@chromium.org
Expand Down
3 changes: 0 additions & 3 deletions net/tools/testserver/OWNERS

This file was deleted.

1 change: 0 additions & 1 deletion testing/OWNERS
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
phajdan.jr@chromium.org
dpranke@chromium.org

# These aren't actually great contact points for this directory, but
Expand Down
1 change: 0 additions & 1 deletion testing/buildbot/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ jochen@chromium.org
kbr@chromium.org
machenbach@chromium.org
maruel@chromium.org
phajdan.jr@chromium.org
sky@chromium.org
tansell@chromium.org
thakis@chromium.org
Expand Down
1 change: 0 additions & 1 deletion testing/scripts/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

dpranke@chromium.org
iannucci@chromium.org
phajdan.jr@chromium.org

# TEAM: infra-dev@chromium.org
# COMPONENT: Infra>Client>Chrome
Expand Down
1 change: 0 additions & 1 deletion third_party/devscripts/OWNERS
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
phajdan.jr@chromium.org
thestig@chromium.org
1 change: 0 additions & 1 deletion third_party/googletest/OWNERS
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
thakis@chromium.org
pwnall@chromium.org
phajdan.jr@chromium.org
dpranke@chromium.org
1 change: 0 additions & 1 deletion third_party/pyftpdlib/OWNERS

This file was deleted.

1 change: 0 additions & 1 deletion tools/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ per-file include_tracer.py=thakis@chromium.org

per-file ipc_messages_log.py=yfriedman@chromium.org

per-file licenses.py=phajdan.jr@chromium.org
per-file licenses.py=torne@chromium.org

per-file remove_stale_pyc_files.py=dtu@chromium.org
Expand Down
2 changes: 0 additions & 2 deletions tools/checklicenses/OWNERS
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
set noparent
phajdan.jr@chromium.org
thestig@chromium.org
1 change: 0 additions & 1 deletion tools/generate_library_loader/OWNERS
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
phajdan.jr@chromium.org
spang@chromium.org
1 change: 0 additions & 1 deletion tools/mb/OWNERS
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
dpranke@chromium.org
jbudorick@chromium.org
phajdan.jr@chromium.org
scottmg@chromium.org
tansell@chromium.org

Expand Down
1 change: 0 additions & 1 deletion tools/tests/OWNERS
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
per-file licenses_test.py=phajdan.jr@chromium.org
per-file licenses_test.py=torne@chromium.org

0 comments on commit 064792e

Please sign in to comment.