GTTF: Add missing virtual destructors.

R=jar
TBR=darin,satorux,fischman,jamesr,sky

BUG=45135

Review URL: https://codereview.chromium.org/12086018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180669 0039d316-1c4b-4281-b951-d872f2087c98

ash/wm/system_modal_container_event_filter_delegate.h

@@ -16,6 +16,8 @@ namespace internal {
 
 class ASH_EXPORT SystemModalContainerEventFilterDelegate {
  public:
+  virtual ~SystemModalContainerEventFilterDelegate() { }
+
   // Returns true if |window| can receive the specified event.
   virtual bool CanWindowReceiveEvents(aura::Window* window) = 0;
 };

base/debug/trace_event_impl.h

@@ -217,6 +217,8 @@ class BASE_EXPORT TraceLog {
   // on-demand.
   class EnabledStateChangedObserver {
    public:
+    virtual ~EnabledStateChangedObserver() { }
+
     // Called just before the tracing system becomes
     // enabled. TraceLog::IsEnabled will return false at this point and trace
     // macros and methods called within the observer will deadlock.

base/prefs/pref_observer.h

@@ -12,6 +12,8 @@ class PrefServiceBase;
 // TODO(joi): Switch to base::Callback and remove this.
 class PrefObserver {
  public:
+  virtual ~PrefObserver() { }
+
   virtual void OnPreferenceChanged(PrefServiceBase* service,
                                    const std::string& pref_name) = 0;
 };

base/prefs/public/pref_change_registrar.h

@@ -19,7 +19,8 @@ class PrefServiceBase;
 // with a PrefStore. Functions much like NotificationRegistrar, but specifically
 // manages observers of preference changes. When the Registrar is destroyed,
 // all registered observers are automatically unregistered with the PrefStore.
-class BASE_PREFS_EXPORT PrefChangeRegistrar : public PrefObserver {
+class BASE_PREFS_EXPORT PrefChangeRegistrar
+    : public NON_EXPORTED_BASE(PrefObserver) {
  public:
   // You can register this type of callback if you need to know the
   // path of the preference that is changing.

base/prefs/public/pref_member.h

@@ -42,7 +42,8 @@ class PrefServiceBase;
 
 namespace subtle {
 
-class BASE_PREFS_EXPORT PrefMemberBase : public PrefObserver {
+class BASE_PREFS_EXPORT PrefMemberBase
+    : public NON_EXPORTED_BASE(PrefObserver) {
  public:
   // Type of callback you can register if you need to know the name of
   // the pref that is changing.

base/threading/post_task_and_reply_impl.h

@@ -25,6 +25,8 @@ namespace internal {
 // may want base::WorkerPool.
 class PostTaskAndReplyImpl {
  public:
+  virtual ~PostTaskAndReplyImpl() { }
+
   // Implementation for MessageLoopProxy::PostTaskAndReply and
   // WorkerPool::PostTaskAndReply.
   bool PostTaskAndReply(const tracked_objects::Location& from_here,

cc/layer_animation_event_observer.h

@@ -10,6 +10,9 @@ namespace cc {
 class CC_EXPORT LayerAnimationEventObserver {
  public:
   virtual void OnAnimationStarted(const AnimationEvent& event) = 0;
+
+ protected:
+  virtual ~LayerAnimationEventObserver() { }
 };
 
 } // namespace cc

cc/layer_tree_host.h

@@ -72,7 +72,7 @@ struct CC_EXPORT RendererCapabilities {
     int maxTextureSize;
 };
 
-class CC_EXPORT LayerTreeHost : public RateLimiterClient {
+class CC_EXPORT LayerTreeHost : public NON_EXPORTED_BASE(RateLimiterClient) {
 public:
     static scoped_ptr<LayerTreeHost> create(LayerTreeHostClient*, const LayerTreeSettings&, scoped_ptr<Thread> implThread);
     virtual ~LayerTreeHost();
@@ -218,7 +218,7 @@ class CC_EXPORT LayerTreeHost : public RateLimiterClient {
     void updateLayers(Layer*, ResourceUpdateQueue&);
     void triggerPrepaint();
 
-    void prioritizeTextures(const LayerList&, OverdrawMetrics&); 
+    void prioritizeTextures(const LayerList&, OverdrawMetrics&);
     void setPrioritiesForSurfaces(size_t surfaceMemoryBytes);
     void setPrioritiesForLayers(const LayerList&);
     size_t calculateMemoryForRenderSurfaces(const LayerList& updateList);

cc/layer_tree_host_impl.h

@@ -60,6 +60,9 @@ class LayerTreeHostImplClient {
     virtual void sendManagedMemoryStats() = 0;
     virtual bool isInsideDraw() = 0;
     virtual void renewTreePriority() = 0;
+
+protected:
+    virtual ~LayerTreeHostImplClient() { }
 };
 
 // LayerTreeHostImpl owns the LayerImpl tree as well as associated rendering state
@@ -93,7 +96,7 @@ class CC_EXPORT LayerTreeHostImpl : public InputHandlerClient,
 
     struct CC_EXPORT FrameData : public RenderPassSink {
         FrameData();
-        ~FrameData();
+        virtual ~FrameData();
 
         std::vector<gfx::Rect> occludingScreenSpaceRects;
         std::vector<gfx::Rect> nonOccludingScreenSpaceRects;

cc/picture_layer_impl.h

@@ -18,8 +18,9 @@ namespace cc {
 struct AppendQuadsData;
 class QuadSink;
 
-class CC_EXPORT PictureLayerImpl : public LayerImpl,
-                                   public PictureLayerTilingClient {
+class CC_EXPORT PictureLayerImpl
+    : public LayerImpl,
+      public NON_EXPORTED_BASE(PictureLayerTilingClient) {
 public:
   static scoped_ptr<PictureLayerImpl> create(LayerTreeImpl* treeImpl, int id)
   {

cc/picture_layer_tiling.h

@@ -31,6 +31,9 @@ class PictureLayerTilingClient {
   virtual gfx::Size CalculateTileSize(
     gfx::Size current_tile_size,
     gfx::Size content_bounds) = 0;
+
+ protected:
+  virtual ~PictureLayerTilingClient() { }
 };
 
 class CC_EXPORT PictureLayerTiling {

cc/rate_limiter.h

@@ -18,6 +18,9 @@ class Thread;
 class RateLimiterClient {
 public:
     virtual void rateLimit() = 0;
+
+protected:
+    virtual ~RateLimiterClient() { }
 };
 
 // A RateLimiter can be used to make sure that a single context does not dominate all execution time.

cc/video_frame_provider.h

@@ -35,6 +35,9 @@ class VideoFrameProvider {
 
     // Notifies the provider's client of a new UV transform matrix to be used.
     virtual void DidUpdateMatrix(const float*) = 0;
+
+   protected:
+    virtual ~Client() { }
   };
 
   // May be called from any thread, but there must be some external guarantee

chrome/browser/certificate_manager_model.h

@@ -31,6 +31,8 @@ class CertificateManagerModel {
 
   class Observer {
    public:
+    virtual ~Observer() { }
+
     // Called to notify the view that the certificate list has been refreshed.
     // TODO(mattm): do a more granular updating strategy?  Maybe retrieve new
     // list of certs, diff against past list, and then notify of the changes?

chrome/browser/download/download_danger_prompt.h

@@ -27,6 +27,8 @@ class DownloadDangerPrompt {
     CANCEL
   };
 
+  virtual ~DownloadDangerPrompt() { }
+
   // Return a new self-deleting DownloadDangerPrompt. |accepted| or |canceled|
   // will be run when the the respective action is invoked. |canceled| may also
   // be called when |item| is either no longer dangerous or no longer in

chrome/browser/extensions/activity_log.h

@@ -43,6 +43,8 @@ class ActivityLog : public ProfileKeyedService,
   // Observers can listen for activity events.
   class Observer {
    public:
+    virtual ~Observer() { }
+
     virtual void OnExtensionActivity(
         const Extension* extension,
         Activity activity,

chrome/browser/extensions/api/developer_private/entry_picker.h

@@ -18,6 +18,8 @@ namespace api {
 
 class EntryPickerClient {
  public:
+  virtual ~EntryPickerClient() { }
+
   virtual void FileSelected(const FilePath& path) = 0;
   virtual void FileSelectionCanceled() = 0;
 };

chrome/browser/extensions/api/page_capture/page_capture_api.h

@@ -29,6 +29,8 @@ class PageCaptureSaveAsMHTMLFunction : public AsyncExtensionFunction {
   // Test specific delegate used to test that the temporary file gets deleted.
   class TestDelegate {
    public:
+    virtual ~TestDelegate() { }
+
     // Called on the UI thread when the temporary file that contains the
     // generated data has been created.
     virtual void OnTemporaryFileCreated(const base::FilePath& temp_file) = 0;

chrome/browser/extensions/app_notify_channel_setup.h

@@ -51,6 +51,8 @@ class AppNotifyChannelSetup
 
   class Delegate {
    public:
+    virtual ~Delegate() { }
+
     // If successful, |channel_id| will be non-empty. On failure, |channel_id|
     // will be empty and |error| will contain an error to report to the JS
     // callback.
@@ -64,6 +66,8 @@ class AppNotifyChannelSetup
   // forcing the return of a certain result to the delegate.
   class InterceptorForTests {
    public:
+    virtual ~InterceptorForTests() { }
+
     virtual void DoIntercept(
         const AppNotifyChannelSetup* setup,
         std::string* result_channel_id,

chrome/browser/extensions/event_router.h

@@ -54,6 +54,8 @@ class EventRouter : public content::NotificationObserver,
   // notified when a listener is added or removed for that |event_name|.
   class Observer {
    public:
+    virtual ~Observer() {}
+
     // Called when a listener is added.
     virtual void OnListenerAdded(const EventListenerInfo& details) {}
     // Called when a listener is removed.

chrome/browser/extensions/extension_function.h

@@ -266,6 +266,8 @@ class UIThreadExtensionFunction : public ExtensionFunction {
   // A delegate for use in testing, to intercept the call to SendResponse.
   class DelegateForTests {
    public:
+    virtual ~DelegateForTests() { }
+
     virtual void OnSendResponse(UIThreadExtensionFunction* function,
                                 bool success,
                                 bool bad_message) = 0;

chrome/browser/extensions/extension_keybinding_registry.h

@@ -32,6 +32,8 @@ class ExtensionKeybindingRegistry : public content::NotificationObserver {
 
   class Delegate {
    public:
+    virtual ~Delegate() { }
+
     // Gets the ActiveTabPermissionGranter for the active tab, if any.
     // If there is no active tab then returns NULL.
     virtual ActiveTabPermissionGranter* GetActiveTabPermissionGranter() = 0;

chrome/browser/extensions/extension_scoped_prefs.h

@@ -8,7 +8,7 @@
 class ExtensionScopedPrefs {
  public:
   ExtensionScopedPrefs() {}
-  ~ExtensionScopedPrefs() {}
+  virtual ~ExtensionScopedPrefs() {}
 
   // Sets the pref |key| for extension |id| to |value|.
   virtual void UpdateExtensionPref(const std::string& id,

chrome/browser/extensions/extension_warning_service.h

@@ -36,6 +36,8 @@ class ExtensionWarningService : public content::NotificationObserver,
  public:
   class Observer {
    public:
+    virtual ~Observer() { }
+
     virtual void ExtensionWarningsChanged() = 0;
   };
 

chrome/browser/favicon/favicon_handler_delegate.h

@@ -16,6 +16,8 @@ class NavigationEntry;
 // about changes.
 class FaviconHandlerDelegate {
  public:
+  virtual ~FaviconHandlerDelegate() { }
+
   // Returns the current NavigationEntry.
   virtual content::NavigationEntry* GetActiveEntry() = 0;
 

chrome/browser/google_apis/auth_service_interface.h

@@ -27,6 +27,8 @@ typedef base::Callback<void(GDataErrorCode error,
 // All functions must be called on UI thread.
 class AuthServiceInterface {
  public:
+  virtual ~AuthServiceInterface() { }
+
   // Adds and removes the observer. AddObserver() should be called before
   // Initialize() as it can change the refresh token.
   virtual void AddObserver(AuthServiceObserver* observer) = 0;

chrome/browser/managed_mode/managed_mode_url_filter.h

@@ -39,6 +39,8 @@ class ManagedModeURLFilter
 
   class Observer {
    public:
+    virtual ~Observer() { }
+
     virtual void OnSiteListUpdated() = 0;
   };
 

chrome/browser/metrics/variations/resource_request_allowed_notifier.h

@@ -41,6 +41,8 @@ class ResourceRequestAllowedNotifier :
   // Observes resource request allowed state changes.
   class Observer {
    public:
+    virtual ~Observer() { }
+
     virtual void OnResourceRequestsAllowed() = 0;
   };
 

chrome/browser/policy/user_info_fetcher.h

@@ -28,6 +28,8 @@ class UserInfoFetcher : public net::URLFetcherDelegate {
  public:
   class Delegate {
    public:
+    virtual ~Delegate() { }
+
     // Invoked when the UserInfo request has succeeded, passing the parsed
     // response in |response|. Delegate may free the UserInfoFetcher in this
     // callback.

chrome/browser/profiles/profile.h

@@ -121,6 +121,8 @@ class Profile : public content::BrowserContext {
 
   class Delegate {
    public:
+    virtual ~Delegate() {}
+
     // Called when creation of the profile is finished.
     virtual void OnProfileCreated(Profile* profile,
                                   bool success,

chrome/browser/signin/about_signin_internals.h

@@ -27,6 +27,8 @@ class AboutSigninInternals
  public:
   class Observer {
    public:
+    virtual ~Observer() { }
+
     // |info| will contain the dictionary of signin_status_ values as indicated
     // in the comments for GetSigninStatus() below.
     virtual void OnSigninStateChanged(scoped_ptr<DictionaryValue> info) = 0;

chrome/browser/signin/signin_internals_util.h

@@ -125,6 +125,8 @@ struct SigninStatus {
 // An Observer class for authentication and token diagnostic information.
 class SigninDiagnosticsObserver {
  public:
+  virtual ~SigninDiagnosticsObserver() {}
+
   // Credentials and signin related changes.
   virtual void NotifySigninValueChanged(const UntimedSigninStatusField& field,
                                         const std::string& value) {}
@@ -138,7 +140,6 @@ class SigninDiagnosticsObserver {
   virtual void NotifyTokenReceivedFailure(const std::string& token_name,
                                           const std::string& error) {}
   virtual void NotifyClearStoredToken(const std::string& token_name) {}
-
 };
 
 } // namespace

chrome/browser/signin/signin_tracker.h

@@ -52,6 +52,8 @@ class SigninTracker : public ProfileSyncServiceObserver,
  public:
   class Observer {
    public:
+    virtual ~Observer() { }
+
     // The GAIA credentials entered by the user have been validated.
     virtual void GaiaCredentialsValid() = 0;
 

chrome/browser/spellchecker/spellcheck_custom_dictionary.h

@@ -67,6 +67,8 @@ class SpellcheckCustomDictionary : public SpellcheckDictionary,
   // Interface to implement for dictionary load and change observers.
   class Observer {
    public:
+    virtual ~Observer() { }
+
     // Called when the custom dictionary has been loaded.
     virtual void OnCustomDictionaryLoaded() = 0;
 

chrome/browser/spellchecker/spellcheck_hunspell_dictionary.h

@@ -31,6 +31,8 @@ class SpellcheckHunspellDictionary
   // Interface to implement for observers of the Hunspell dictionary.
   class Observer {
    public:
+    virtual ~Observer() { }
+
     // The dictionary has been initialized.
     virtual void OnHunspellDictionaryInitialized() = 0;
 

chrome/browser/tab_contents/render_view_context_menu.h

@@ -103,6 +103,8 @@ struct WebPluginAction;
 //
 class RenderViewContextMenuProxy {
  public:
+  virtual ~RenderViewContextMenuProxy() { }
+
   // Add a menu item to a context menu.
   virtual void AddMenuItem(int command_id, const string16& title) = 0;
   virtual void AddCheckItem(int command_id, const string16& title) = 0;

chrome/browser/ui/app_modal_dialogs/native_app_modal_dialog.h

@@ -11,6 +11,8 @@ class JavaScriptAppModalDialog;
 
 class NativeAppModalDialog {
  public:
+  virtual ~NativeAppModalDialog() { }
+
   // Returns the buttons to be shown. See ui::DialogButton for which buttons can
   // be returned.
   virtual int GetAppModalDialogButtons() const = 0;

chrome/browser/ui/autofill/autofill_popup_delegate.h

@@ -11,6 +11,8 @@
 // of events by the controller.
 class AutofillPopupDelegate {
  public:
+  virtual ~AutofillPopupDelegate() { }
+
   // Called when the autofill suggestion indicated by |identifier| has been
   // temporarily selected (e.g., hovered).
   virtual void DidSelectSuggestion(int identifier) = 0;

chrome/browser/ui/base_window.h

@@ -19,6 +19,8 @@ class SkRegion;
 
 class BaseWindow {
  public:
+  virtual ~BaseWindow() { }
+
   // Returns true if the window is currently the active/focused window.
   virtual bool IsActive() const = 0;