Skip to content

Commit

Permalink
Add icon to gcp_installer / gcp_setup executables.
Browse files Browse the repository at this point in the history
Bug: 899236
Change-Id: Id541261326bfd44528b08ebc6b0edbe5fafb317f
Reviewed-on: https://chromium-review.googlesource.com/c/1370313
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Tien Mai <tienmai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615563}
  • Loading branch information
tienhmai authored and Commit Bot committed Dec 11, 2018
1 parent a737e67 commit 08ccc70
Show file tree
Hide file tree
Showing 3 changed files with 36 additions and 0 deletions.
19 changes: 19 additions & 0 deletions chrome/credential_provider/setup/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import("//build/nocompile.gni")
import("//chrome/process_version_rc_template.gni")
import("//testing/libfuzzer/fuzzer_test.gni")
import("//testing/test.gni")
import("//tools/grit/grit_rule.gni")

process_version_rc_template("version") {
template_file = "gcp_setup.rc.version"
Expand All @@ -32,10 +33,27 @@ source_set("common") {
]
}

grit("setup_resources") {
source = "gcp_setup_resources.grd"
inputs = [
"gcp_icon.ico",
]
outputs = [
"grit/gcp_setup_resources.h",
"grit/gcp_setup_resources.rc",
]
resource_ids = ""
grit_flags = [
"-E",
"root_gen_dir=" + rebase_path(root_gen_dir, root_build_dir),
]
}

# Builds a self extracting 7-zip binary using the 7-zip SFX sources but with
# the credential provider's version resources.
executable("gcp_sfx") {
deps = [
":setup_resources",
":version",
"//third_party/lzma_sdk/Util/SfxSetup:7zS2_source",
]
Expand All @@ -50,6 +68,7 @@ executable("gcp_setup") {
]
deps = [
":common",
":setup_resources",
"../eventlog:gcp_eventlog_messages",
"../gaiacp:common",
"//chrome/common:version_header",
Expand Down
Binary file added chrome/credential_provider/setup/gcp_icon.ico
Binary file not shown.
17 changes: 17 additions & 0 deletions chrome/credential_provider/setup/gcp_setup_resources.grd
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<?xml version="1.0" encoding="UTF-8"?>
<grit current_release="1" latest_public_release="0">
<outputs>
<output filename="grit/gcp_setup_resources.h" type="rc_header">
<emit emit_type='prepend'></emit>
</output>
<output filename="grit/gcp_setup_resources.rc" type="rc_all" />
</outputs>
<translations/>
<release seq="1">
<includes>
<include name="IDI_GCP_ICON"
file="gcp_icon.ico"
type="ICON" />
</includes>
</release>
</grit>

0 comments on commit 08ccc70

Please sign in to comment.