HTMLAreaElement should expose download and rel attributes.

HTMLAreaElement should define IDL `download` and `rel` attributes for faster access. Firefox implements both of them, Safari/Edge has only `rel` (WebKit has no `download` yet). BUG=605552 Review-Url: https://codereview.chromium.org/2050643002 Cr-Commit-Position: refs/heads/master@{#406541}
Denger-Network · Jul 20, 2016 · 0bf0830 · 0bf0830
1 parent 5e06bcd
commit 0bf0830
Show file tree

Hide file tree

Showing 7 changed files with 56 additions and 1 deletion.
diff --git a/third_party/WebKit/LayoutTests/fast/dom/HTMLAreaElement/area-download-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/HTMLAreaElement/area-download-expected.txt
@@ -0,0 +1,2 @@
+Downloading URL with suggested filename "foo"
+
diff --git a/third_party/WebKit/LayoutTests/fast/dom/HTMLAreaElement/area-download.html b/third_party/WebKit/LayoutTests/fast/dom/HTMLAreaElement/area-download.html
@@ -0,0 +1,39 @@
+<!DOCTYPE html>
+<html>
+<head>
+<script type='text/javascript'>
+if (window.testRunner) {
+  testRunner.dumpAsText();
+  testRunner.waitUntilExternalURLLoad();
+}
+</script>
+</head>
+<body>
+<map name="imagemap">
+  <area id="area" download="foo" shape="rect" coords="0, 0, 100, 100">
+</map>
+<img width="100" height="100" usemap="#imagemap"/>
+<script>
+function click(elmt)
+{
+    if (!window.eventSender) {
+        alert('Click the area to run the test.');
+        return;
+    }
+    eventSender.mouseMoveTo(elmt.offsetLeft + elmt.offsetWidth / 2, elmt.offsetTop + elmt.offsetHeight / 2);
+    eventSender.mouseDown();
+    eventSender.mouseUp();
+}
+
+function runTest()
+{
+    var string = "<!doctype html><html><head><title>Title</title><script>if (window.testRunner) testRunner.dumpAsText(); </" + "script></head><body>PASS</body></html>";
+    var blob = new Blob([string], {type: "text/html"});
+    var area = document.getElementById("area");
+    area.href = window.URL.createObjectURL(blob);
+    click(area);
+}
+runTest();
+</script>
+</body>
+</html>
diff --git a/...bKit/LayoutTests/virtual/stable/webexposed/element-instance-property-listing-expected.txt b/...bKit/LayoutTests/virtual/stable/webexposed/element-instance-property-listing-expected.txt
@@ -251,6 +251,7 @@ html element applet
 html element area
     property alt
     property coords
+    property download
     property hash
     property host
     property hostname
@@ -263,6 +264,7 @@ html element area
     property port
     property protocol
     property referrerPolicy
+    property rel
     property search
     property shape
     property target

diff --git a/..._party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt b/..._party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
@@ -1389,6 +1389,7 @@ interface HTMLAreaElement : HTMLElement
     attribute @@toStringTag
     getter alt
     getter coords
+    getter download
     getter hash
     getter host
     getter hostname
@@ -1401,6 +1402,7 @@ interface HTMLAreaElement : HTMLElement
     getter port
     getter protocol
     getter referrerPolicy
+    getter rel
     getter search
     getter shape
     getter target
@@ -1409,6 +1411,7 @@ interface HTMLAreaElement : HTMLElement
     method toString
     setter alt
     setter coords
+    setter download
     setter hash
     setter host
     setter hostname
@@ -1420,6 +1423,7 @@ interface HTMLAreaElement : HTMLElement
     setter port
     setter protocol
     setter referrerPolicy
+    setter rel
     setter search
     setter shape
     setter target

diff --git a/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt b/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
@@ -277,6 +277,7 @@ html element applet
 html element area
     property alt
     property coords
+    property download
     property hash
     property host
     property hostname
@@ -289,6 +290,7 @@ html element area
     property port
     property protocol
     property referrerPolicy
+    property rel
     property search
     property shape
     property target

diff --git a/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt b/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
@@ -1871,6 +1871,7 @@ interface HTMLAreaElement : HTMLElement
     attribute @@toStringTag
     getter alt
     getter coords
+    getter download
     getter hash
     getter host
     getter hostname
@@ -1883,6 +1884,7 @@ interface HTMLAreaElement : HTMLElement
     getter port
     getter protocol
     getter referrerPolicy
+    getter rel
     getter search
     getter shape
     getter target
@@ -1891,6 +1893,7 @@ interface HTMLAreaElement : HTMLElement
     method toString
     setter alt
     setter coords
+    setter download
     setter hash
     setter host
     setter hostname
@@ -1902,6 +1905,7 @@ interface HTMLAreaElement : HTMLElement
     setter port
     setter protocol
     setter referrerPolicy
+    setter rel
     setter search
     setter shape
     setter target

diff --git a/third_party/WebKit/Source/core/html/HTMLAreaElement.idl b/third_party/WebKit/Source/core/html/HTMLAreaElement.idl
@@ -23,11 +23,13 @@
 interface HTMLAreaElement : HTMLElement {
     [CEReactions, Reflect] attribute DOMString alt;
     [CEReactions, Reflect] attribute DOMString coords;
+    [CEReactions, Reflect] attribute DOMString download;
     [CEReactions, Reflect] attribute DOMString shape;
     [CEReactions, Reflect] attribute DOMString target;
     // FIXME: ping should be a DOMTokenList.
     [CEReactions, Reflect] attribute DOMString ping;
-    // FIXME: download, rel, relList are missing
+    [CEReactions, Reflect] attribute DOMString rel;
+    // FIXME: relList is missing
     [CEReactions, Reflect, ReflectOnly=("","no-referrer","origin","no-referrer-when-downgrade","origin-when-cross-origin","unsafe-url"), ReflectMissing="", ReflectInvalid=""] attribute DOMString referrerPolicy;
 
     // obsolete members