Revert piece of "De-duplicate job_settings parsing code." r231501

UseDefaultSettingsis call is not necessary. Review URL: https://codereview.chromium.org/54273002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232371 0039d316-1c4b-4281-b951-d872f2087c98
Denger-Network · Nov 1, 2013 · 0c5e302 · 0c5e302
1 parent 058308c
commit 0c5e302
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/printing/printing_context.cc b/printing/printing_context.cc
@@ -47,9 +47,6 @@ PrintingContext::Result PrintingContext::UpdatePrintSettings(
     const PageRanges& ranges) {
   ResetSettings();
 
-  if (settings_.dpi() == 0)
-    UseDefaultSettings();
-
   if (!PrintSettingsInitializer::InitSettings(job_settings, ranges,
                                               &settings_)) {
     NOTREACHED();

diff --git a/printing/printing_context_no_system_dialog.cc b/printing/printing_context_no_system_dialog.cc
@@ -81,6 +81,10 @@ PrintingContext::Result PrintingContextNoSystemDialog::UseDefaultSettings() {
 PrintingContext::Result PrintingContextNoSystemDialog::UpdatePrinterSettings(
     bool target_is_pdf,
     bool external_preview) {
+
+  if (settings_.dpi() == 0)
+    UseDefaultSettings();
+
   return OK;
 }