Skip to content

Commit

Permalink
Remove //media:test_support dependency on //media/gpu:test_support
Browse files Browse the repository at this point in the history
Since //media does not depend on //media/gpu, //media:test_support
should not depend on //media/gpu:test_support (which depends on
//media/gpu). Otherwise even if we just want to use some
simple util test functions we have to drag in //media/gpu which
drags in a lot of other dependencies.

Tbr: jcliang@chromium.org
Bug: 974269
Test: No functionality change.
Change-Id: I522ef0162867997e90b6ec80ad2c58f97175c5c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777106
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693247}
  • Loading branch information
xhwang-chromium authored and Commit Bot committed Sep 4, 2019
1 parent c546ce6 commit 0c6752b
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 2 deletions.
1 change: 1 addition & 0 deletions components/chromeos_camera/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,7 @@ test("jpeg_decode_accelerator_unittest") {
"//base",
"//media:test_support",
"//media/capture:chromeos_test_utils",
"//media/gpu",
"//media/gpu:buildflags",
"//media/gpu/test:helpers",
"//media/parsers",
Expand Down
1 change: 0 additions & 1 deletion media/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,6 @@ source_set("test_support") {
"//media/base/android:test_support",
"//media/filters:test_support",
"//media/formats:test_support",
"//media/gpu:test_support",
"//media/video:test_support",
]
}
Expand Down
1 change: 1 addition & 0 deletions media/filters/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,7 @@ source_set("unit_tests") {
sources += [ "fuchsia/fuchsia_video_decoder_unittest.cc" ]
deps += [
"//components/viz/test:test_support",
"//gpu/command_buffer/client",
"//third_party/fuchsia-sdk/sdk:sys_cpp",
"//third_party/fuchsia-sdk/sdk:sysmem",
]
Expand Down
3 changes: 2 additions & 1 deletion media/gpu/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ component("gpu") {
"//components/arc/mojom:media",
"//components/arc/video_accelerator",
"//components/mirroring/service:mirroring_service",
"//components/chromeos_camera/*",
"//components/viz/service/main",
"//content/gpu:*",
"//content/renderer:*",
Expand Down Expand Up @@ -530,7 +531,7 @@ if (use_v4l2_codec || use_vaapi || is_mac || is_win) {
}

static_library("test_support") {
visibility = [ "//media:test_support" ]
visibility = [ "//media/gpu/*" ]
testonly = true
sources = [
"test/fake_command_buffer_helper.cc",
Expand Down
1 change: 1 addition & 0 deletions media/gpu/ipc/service/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ source_set("unit_tests") {
"//base",
"//base/test:test_support",
"//media:test_support",
"//media/gpu:test_support",
"//testing/gmock",
"//testing/gtest",
]
Expand Down

0 comments on commit 0c6752b

Please sign in to comment.