Skip to content

Commit

Permalink
ash: Sort some dependencies in some build files
Browse files Browse the repository at this point in the history 
Change-Id: I08fa6fae1598ea90d36e92c3073d31b61cb25a59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5691275
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1325917}
  • Loading branch information
@GeorgNeis @pull
GeorgNeis authored and pull[bot] committed Jul 11, 2024
1 parent 1f3b77a commit 1173184
Show file tree
Hide file tree
Showing 2 changed files with 38 additions and 38 deletions.
32 changes: 16 additions & 16 deletions chrome/browser/ash/BUILD.gn
View file
Original file line number Diff line number Diff line change
Expand Up @@ -796,13 +796,16 @@ static_library("ash") {

allow_circular_includes_from = [
"//chrome/browser/apps/almanac_api_client",
"//chrome/browser/apps/app_service",
"//chrome/browser/apps/app_service/app_icon",
"//chrome/browser/apps/platform_apps/api",
"//chrome/browser/ash/accessibility",
"//chrome/browser/ash/accessibility/live_caption",
"//chrome/browser/ash/accessibility/service",
"//chrome/browser/ash/account_manager",
"//chrome/browser/ash/android_sms",
"//chrome/browser/ash/app_list",
"//chrome/browser/ash/app_list/search/local_image_search",
"//chrome/browser/ash/app_mode",
"//chrome/browser/ash/app_mode/auto_sleep",
"//chrome/browser/ash/app_mode/web_app",
Expand All @@ -825,7 +828,6 @@ static_library("ash") {
"//chrome/browser/ash/arc/nearby_share",
"//chrome/browser/ash/arc/notification",
"//chrome/browser/ash/arc/optin",
"//chrome/browser/ash/fileapi",
"//chrome/browser/ash/arc/policy",
"//chrome/browser/ash/arc/process",
"//chrome/browser/ash/arc/session",
Expand All @@ -848,25 +850,26 @@ static_library("ash") {
"//chrome/browser/ash/crosapi",
"//chrome/browser/ash/cryptauth",
"//chrome/browser/ash/customization",
"//chrome/browser/ash/dbus",
"//chrome/browser/ash/dbus/vm",
"//chrome/browser/ash/device_name",
"//chrome/browser/ash/device_sync",
"//chrome/browser/ash/diagnostics",
"//chrome/browser/ash/drive",
"//chrome/browser/ash/dbus",
"//chrome/browser/ash/dbus/vm",
"//chrome/browser/ash/early_prefs",
"//chrome/browser/ash/eche_app",
"//chrome/browser/ash/events",
"//chrome/browser/ash/exo",
"//chrome/browser/ash/extended_updates",
"//chrome/browser/ash/file_manager",
"//chrome/browser/ash/file_manager/virtual_tasks",
"//chrome/browser/ash/file_suggest",
"//chrome/browser/ash/extensions",
"//chrome/browser/ash/extensions/autotest_private",
"//chrome/browser/ash/extensions/file_manager",
"//chrome/browser/ash/extensions/login_screen_ui",
"//chrome/browser/ash/extensions/users_private",
"//chrome/browser/ash/fileapi",
"//chrome/browser/ash/file_manager",
"//chrome/browser/ash/file_manager/virtual_tasks",
"//chrome/browser/ash/file_suggest",
"//chrome/browser/ash/first_run",
"//chrome/browser/ash/floating_workspace",
"//chrome/browser/ash/fusebox",
Expand Down Expand Up @@ -923,19 +926,20 @@ static_library("ash") {
"//chrome/browser/ash/printing/enterprise",
"//chrome/browser/ash/printing/history",
"//chrome/browser/ash/printing/oauth2",
"//chrome/browser/ash/printing/print_preview",
"//chrome/browser/ash/printing/print_management",
"//chrome/browser/ash/profiles",
"//chrome/browser/ash/printing/print_preview",
"//chrome/browser/ash/privacy_hub",
"//chrome/browser/ash/profiles",
"//chrome/browser/ash/quick_pair",
"//chrome/browser/ash/release_notes",
"//chrome/browser/ash/remote_apps",
"//chrome/browser/ash/secure_channel",
"//chrome/browser/ash/smb_client",
"//chrome/browser/ash/smb_client/fileapi",
"//chrome/browser/ash/scalable_iph",
"//chrome/browser/ash/scanning",
"//chrome/browser/ash/secure_channel",
"//chrome/browser/ash/sharesheet",
"//chrome/browser/ash/shimless_rma",
"//chrome/browser/ash/smb_client",
"//chrome/browser/ash/smb_client/fileapi",
"//chrome/browser/ash/sparky",
"//chrome/browser/ash/system_logs",
"//chrome/browser/ash/system_web_apps",
Expand All @@ -946,19 +950,15 @@ static_library("ash") {
"//chrome/browser/ash/system_web_apps/apps/personalization_app",
"//chrome/browser/ash/tether",
"//chrome/browser/ash/trusted_vault",
"//chrome/browser/ash/app_list/search/local_image_search",
"//chrome/browser/ash/usb",
"//chrome/browser/ash/video_conference",
"//chrome/browser/ash/wallpaper",
"//chrome/browser/ash/wallpaper_handlers",
"//chrome/browser/chromeos",
"//chrome/browser/extensions",
"//chrome/browser/google",
"//chrome/browser/sync",
"//chrome/browser/ash/scanning",
"//chrome/browser/apps/app_service",
"//chrome/browser/apps/app_service/app_icon",
"//chrome/browser/policy:onc",
"//chrome/browser/sync",
"//chrome/browser/ui/ash/system_web_apps",
"//chrome/browser/web_applications",
]
Expand Down
44 changes: 22 additions & 22 deletions chrome/browser/ui/BUILD.gn
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4191,24 +4191,15 @@ static_library("ui") {
]

allow_circular_includes_from += [
"//chrome/browser/ash/app_list/search/local_image_search",
"//chrome/browser/ash",
"//chrome/browser/ash/account_manager",
"//chrome/browser/ash/accessibility",
"//chrome/browser/ash/accessibility/live_caption",
"//chrome/browser/ash/accessibility/service",
"//chrome/browser/ash/borealis",
"//chrome/browser/ash/annotator",
"//chrome/browser/ash/attestation",
"//chrome/browser/ash/account_manager",
"//chrome/browser/ash/android_sms",
"//chrome/browser/ash/input_method",
"//chrome/browser/ash/input_method/ui",
"//chrome/browser/ash/child_accounts",
"//chrome/browser/ash/child_accounts/on_device_controls",
"//chrome/browser/ash/child_accounts/parent_access_code",
"//chrome/browser/ash/child_accounts/time_limits",
"//chrome/browser/ash/file_manager",
"//chrome/browser/ash/file_manager/virtual_tasks",
"//chrome/browser/ash/annotator",
"//chrome/browser/ash/app_list",
"//chrome/browser/ash/app_list/search/local_image_search",
"//chrome/browser/ash/app_restore",
"//chrome/browser/ash/apps",
"//chrome/browser/ash/arc",
Expand All @@ -4220,41 +4211,50 @@ static_library("ui") {
"//chrome/browser/ash/arc/fileapi",
"//chrome/browser/ash/arc/input_method_manager",
"//chrome/browser/ash/arc/input_overlay",
"//chrome/browser/ash/arc/intent_helper",
"//chrome/browser/ash/arc/instance_throttle",
"//chrome/browser/ash/arc/intent_helper",
"//chrome/browser/ash/arc/metrics",
"//chrome/browser/ash/arc/nearby_share",
"//chrome/browser/ash/arc/notification",
"//chrome/browser/ash/arc/optin",
"//chrome/browser/ash/arc/policy",
"//chrome/browser/ash/arc/pip",
"//chrome/browser/ash/arc/policy",
"//chrome/browser/ash/arc/print_spooler",
"//chrome/browser/ash/arc/session",
"//chrome/browser/ash/arc/sharesheet",
"//chrome/browser/ash/arc/survey",
"//chrome/browser/ash/arc/tracing",
"//chrome/browser/ash/arc/util",
"//chrome/browser/ash/arc/vmm",
"//chrome/browser/ash/arc/wallpaper",
"//chrome/browser/ash/arc/window_predictor",
"//chrome/browser/ash/arc/vmm",
"//chrome/browser/ash/attestation",
"//chrome/browser/ash/base",
"//chrome/browser/ash/dbus/vm",
"//chrome/browser/ash/borealis",
"//chrome/browser/ash/camera_mic",
"//chrome/browser/ash/child_accounts",
"//chrome/browser/ash/child_accounts/on_device_controls",
"//chrome/browser/ash/child_accounts/parent_access_code",
"//chrome/browser/ash/child_accounts/time_limits",
"//chrome/browser/ash/crosapi",
"//chrome/browser/ash/app_list",
"//chrome/browser/ash/customization",
"//chrome/browser/ash/dbus/vm",
"//chrome/browser/ash/eche_app",
"//chrome/browser/ash/extended_updates",
"//chrome/browser/ash/file_suggest",
"//chrome/browser/ash/extensions",
"//chrome/browser/ash/extensions/autotest_private",
"//chrome/browser/ash/extensions/file_manager",
"//chrome/browser/ash/file_manager",
"//chrome/browser/ash/file_manager/virtual_tasks",
"//chrome/browser/ash/file_suggest",
"//chrome/browser/ash/floating_workspace",
"//chrome/browser/ash/geolocation",
"//chrome/browser/ash/growth",
"//chrome/browser/ash/guest_os",
"//chrome/browser/ash/guest_os/public",
"//chrome/browser/ash/hats",
"//chrome/browser/ash/input_method",
"//chrome/browser/ash/input_method/ui",
"//chrome/browser/ash/kerberos",
"//chrome/browser/ash/lock_screen_apps",
"//chrome/browser/ash/login",
Expand Down Expand Up @@ -4291,12 +4291,13 @@ static_library("ui") {
"//chrome/browser/ash/power",
"//chrome/browser/ash/power/ml",
"//chrome/browser/ash/printing/oauth2",
"//chrome/browser/ash/printing/print_preview",
"//chrome/browser/ash/printing/print_management",
"//chrome/browser/ash/printing/print_preview",
"//chrome/browser/ash/privacy_hub",
"//chrome/browser/ash/profiles",
"//chrome/browser/ash/remote_apps",
"//chrome/browser/ash/quick_pair",
"//chrome/browser/ash/release_notes",
"//chrome/browser/ash/remote_apps",
"//chrome/browser/ash/scalable_iph",
"//chrome/browser/ash/sharesheet",
"//chrome/browser/ash/scanning",
Expand All @@ -4311,7 +4312,6 @@ static_library("ui") {
"//chrome/browser/ash/system_web_apps/apps/projector_app",
"//chrome/browser/ash/system_web_apps/apps/vc_background_ui",
"//chrome/browser/ash/tether",
"//chrome/browser/ash/quick_pair",
"//chrome/browser/ash/usb",
"//chrome/browser/chromeos/extensions/wm",
]
Expand Down

0 comments on commit 1173184

Please sign in to comment.