Skip to content

Commit

Permalink
[Extensions Metrics] Stop recording InstallCause for unpack outcomes
Browse files Browse the repository at this point in the history
Stop recording Extensions.UnpackSuccessInstallCause and
Extensions.UnpackFailureInstallCause. We haven't been looking at them
lately.

Bug: 975376
Change-Id: I3f1fac7fb981eaf8bb3c9fa23a96b8f9ab857db4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703421
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677959}
  • Loading branch information
rdcronin authored and Commit Bot committed Jul 16, 2019
1 parent 4230a31 commit 121548c
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 9 deletions.
7 changes: 0 additions & 7 deletions chrome/browser/extensions/crx_installer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -482,9 +482,6 @@ void CrxInstaller::OnUnpackFailure(const CrxInstallError& error) {
UMA_HISTOGRAM_ENUMERATION("Extensions.UnpackFailureInstallSource",
install_source(), Manifest::NUM_LOCATIONS);

UMA_HISTOGRAM_ENUMERATION("Extensions.UnpackFailureInstallCause",
install_cause(),
extension_misc::NUM_INSTALL_CAUSES);
ReportFailureFromFileThread(error);
}

Expand All @@ -501,10 +498,6 @@ void CrxInstaller::OnUnpackSuccess(
install_source(), Manifest::NUM_LOCATIONS);


UMA_HISTOGRAM_ENUMERATION("Extensions.UnpackSuccessInstallCause",
install_cause(),
extension_misc::NUM_INSTALL_CAUSES);

extension_ = extension;
temp_dir_ = temp_dir;
dnr_ruleset_checksum_ = dnr_ruleset_checksum;
Expand Down
10 changes: 8 additions & 2 deletions tools/metrics/histograms/histograms.xml
Original file line number Diff line number Diff line change
Expand Up @@ -42460,7 +42460,10 @@ uploading your change for review.
</histogram>

<histogram name="Extensions.UnpackFailureInstallCause"
enum="ExtensionInstallCause" expires_after="M77">
enum="ExtensionInstallCause">
<obsolete>
Stopped recording 2019-07.
</obsolete>
<owner>extensions-core@chromium.org</owner>
<summary>
Count failing CRX installs, grouped by the way an extension can be
Expand All @@ -42479,7 +42482,10 @@ uploading your change for review.
</histogram>

<histogram name="Extensions.UnpackSuccessInstallCause"
enum="ExtensionInstallCause" expires_after="M77">
enum="ExtensionInstallCause">
<obsolete>
Stopped recording 2019-07.
</obsolete>
<owner>extensions-core@chromium.org</owner>
<summary>
Count successful CRX installs, grouped by the cause of the install.
Expand Down

0 comments on commit 121548c

Please sign in to comment.