[Signin][Android] Enable MobileIdentityConsistency in testing config

Adds MobileIdentityConsistency to testing/variations/fieldtrial_testing_config.json and adds explicit @DisableFeatures to the affected tests. Bug: 1128916, 1142467 Change-Id: I25afb6de05d2ce232f1006a8497884f9db18d52e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489895 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#820973}
Denger-Network · Oct 26, 2020 · 12814ab · 12814ab
1 parent c9693c9
commit 12814ab
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 2 deletions.
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java
@@ -150,6 +150,7 @@ public void tearDown() {
     @Test
     @MediumTest
     @Feature({"NewTabPage", "FeedNewTabPage", "RenderTest"})
+    @Features.DisableFeatures(ChromeFeatureList.MOBILE_IDENTITY_CONSISTENCY)
     public void testRender_FocusFakeBox() throws Exception {
         ScrimCoordinator scrimCoordinator = mActivityTestRule.getActivity()
                                                     .getRootUiCoordinatorForTesting()
@@ -164,6 +165,7 @@ public void testRender_FocusFakeBox() throws Exception {
     @Test
     @SmallTest
     @Feature({"NewTabPage", "FeedNewTabPage", "RenderTest"})
+    @Features.DisableFeatures(ChromeFeatureList.MOBILE_IDENTITY_CONSISTENCY)
     public void testRender_SignInPromo() throws Exception {
         // Scroll to the sign in promo in case it is not visible.
         onView(instanceOf(RecyclerView.class))

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/RecentTabsPageTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/RecentTabsPageTest.java
@@ -99,6 +99,7 @@ public void testRecentlyClosedTabs() throws ExecutionException {
     @Test
     @LargeTest
     @Feature("RenderTest")
+    @Features.DisableFeatures({ChromeFeatureList.MOBILE_IDENTITY_CONSISTENCY})
     public void testPersonalizedSigninPromoInRecentTabsPage() throws Exception {
         mAccountManagerTestRule.addAccount(mAccountManagerTestRule.createProfileDataFromName(
                 AccountManagerTestRule.TEST_ACCOUNT_EMAIL));

diff --git a/.../android/javatests/src/org/chromium/chrome/browser/settings/MainSettingsFragmentTest.java b/.../android/javatests/src/org/chromium/chrome/browser/settings/MainSettingsFragmentTest.java
@@ -165,8 +165,10 @@ private void configureMockSearchEngine() {
     @LargeTest
     @Feature({"RenderTest"})
     @EnableFeatures({ChromeFeatureList.SAFE_BROWSING_SECTION_UI})
-    @DisableFeatures({ChromeFeatureList.SAFETY_CHECK_ANDROID})
-    public void testRenderDifferentSignedInStates() throws IOException {
+    @DisableFeatures(
+            {ChromeFeatureList.SAFETY_CHECK_ANDROID, ChromeFeatureList.MOBILE_IDENTITY_CONSISTENCY})
+    public void
+    testRenderDifferentSignedInStates() throws IOException {
         launchSettingsActivity();
         View view = mSettingsActivityTestRule.getActivity()
                             .findViewById(android.R.id.content)
@@ -184,6 +186,7 @@ public void testRenderDifferentSignedInStates() throws IOException {
     @Feature({"RenderTest"})
     @EnableFeatures(
             {ChromeFeatureList.SAFETY_CHECK_ANDROID, ChromeFeatureList.SAFE_BROWSING_SECTION_UI})
+    @DisableFeatures(ChromeFeatureList.MOBILE_IDENTITY_CONSISTENCY)
     public void
     testRenderDifferentSignedInStatesWithSafetyCheck() throws IOException {
         launchSettingsActivity();
@@ -207,6 +210,7 @@ public void testRenderDifferentSignedInStates() throws IOException {
     @Test
     @SmallTest
     @EnableFeatures({ChromeFeatureList.PASSWORD_CHECK, ChromeFeatureList.SAFETY_CHECK_ANDROID})
+    @DisableFeatures(ChromeFeatureList.MOBILE_IDENTITY_CONSISTENCY)
     public void testStartup() {
         launchSettingsActivity();
 
@@ -367,6 +371,7 @@ public void testSearchEngineDisabled() {
      */
     @Test
     @SmallTest
+    @DisableFeatures({ChromeFeatureList.MOBILE_IDENTITY_CONSISTENCY})
     public void testAccountSignIn() {
         launchSettingsActivity();
 

diff --git a/testing/variations/fieldtrial_testing_config.json b/testing/variations/fieldtrial_testing_config.json
@@ -4372,6 +4372,21 @@
             ]
         }
     ],
+    "MobileIdentityConsistency": [
+        {
+            "platforms": [
+                "android"
+            ],
+            "experiments": [
+                {
+                    "name": "Enabled",
+                    "enable_features": [
+                        "MobileIdentityConsistency"
+                    ]
+                }
+            ]
+        }
+    ],
     "MyChromeEverywhere": [
         {
             "platforms": [