Skip to content

Commit

Permalink
CrOS app list: Apply the parallel tweak to app list _target visibility_
Browse files Browse the repository at this point in the history
This applies the same change made in CL 1814222 (for the _visibility_
chain of events), to the _target visibility_ chain of events and
observers.

This fixes tests that are failing with pending CL 1832634.

Bug: 1006013
Change-Id: I6992f16d79393b16d3813090ec3d69090335fe14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834653
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702062}
  • Loading branch information
Manu Cornet authored and Commit Bot committed Oct 2, 2019
1 parent 590a5f7 commit 1431337
Showing 1 changed file with 10 additions and 8 deletions.
18 changes: 10 additions & 8 deletions ash/app_list/app_list_controller_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1296,15 +1296,17 @@ void AppListControllerImpl::NotifyAppListTargetVisibilityChanged(
}

// Notify chrome of target visibility changes.
if (client_)
client_->OnAppListTargetVisibilityChanged(real_target_visibility);

for (auto& observer : observers_)
observer.OnAppListTargetVisibilityChanged(real_target_visibility,
display_id);
if (last_target_visible_ != real_target_visibility) {
if (client_)
client_->OnAppListTargetVisibilityChanged(real_target_visibility);

last_target_visible_ = real_target_visibility;
last_target_visible_display_id_ = display_id;
for (auto& observer : observers_) {
observer.OnAppListTargetVisibilityChanged(real_target_visibility,
display_id);
}
last_target_visible_ = real_target_visibility;
last_target_visible_display_id_ = display_id;
}
}

////////////////////////////////////////////////////////////////////////////////
Expand Down

0 comments on commit 1431337

Please sign in to comment.