Skip to content

Commit

Permalink
Fix flags for Chromecast browser test on internal infrastructure
Browse files Browse the repository at this point in the history
The media playback test was recently added:
https://codereview.chromium.org/1431193005/

and requires specific switches:
* local file access required to load test media
* cma pipeline explicitly enabled in order to test that
* cast ozone platform enabled in order to test overlay frames

These tests have been failing on internal infrastructure (tot build)
because the switches were only configured in testing/buildbot (for
running on Chromium bots).

BUG=

Review URL: https://codereview.chromium.org/1466633004

Cr-Commit-Position: refs/heads/master@{#361134}
  • Loading branch information
halliwell authored and Commit bot committed Nov 23, 2015
1 parent b21a4e0 commit 146527a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion chromecast/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ cast_test_group("cast_tests") {
"//chromecast/media:cast_media_unittests",
]

filters += [ "cast_shell_browser_test --no-sandbox --disable-gpu" ]
filters += [ "cast_shell_browser_test --no-sandbox --enable-local-file-accesses --enable-cma-media-pipeline --ozone-platform=cast" ]
}

if (!disable_display) {
Expand Down
2 changes: 1 addition & 1 deletion chromecast/chromecast_tests.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@
],
'variables': {
'filters': [
'cast_shell_browser_test --no-sandbox --disable-gpu',
'cast_shell_browser_test --no-sandbox --enable-local-file-accesses --enable-cma-media-pipeline --ozone-platform=cast',
],
},
}],
Expand Down

0 comments on commit 146527a

Please sign in to comment.