Skip to content

Commit

Permalink
Misc fixes for the ChromeOS and Win x64 GN builds.
Browse files Browse the repository at this point in the history
TBR=brettw@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1098223003

Cr-Commit-Position: refs/heads/master@{#326235}
  • Loading branch information
dpranke committed Apr 22, 2015
1 parent 8ccde8a commit 1562114
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 1 deletion.
12 changes: 11 additions & 1 deletion chrome/test/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -741,6 +741,9 @@ if (!is_android) {
deps += [
#'chrome.gyp:chrome_nacl_win64', TODO(GYP)
]
configs -= [ "//build/config/win:default_incremental_linking" ]
configs +=
[ "//build/config/win:default_large_module_incremental_linking" ]
}
if (is_linux) {
deps += [
Expand Down Expand Up @@ -1143,6 +1146,9 @@ if (!is_android) {
"//third_party/wtl",
"//ui/resources",
]
configs -= [ "//build/config/win:default_incremental_linking" ]
configs +=
[ "//build/config/win:default_large_module_incremental_linking" ]
} else {
sources -= [ "../app/chrome_version.rc.version" ]
}
Expand Down Expand Up @@ -1730,7 +1736,11 @@ if (!is_android) {
"//testing/perf",
]

if (!is_win) {
if (is_win) {
configs -= [ "//build/config/win:default_incremental_linking" ]
configs +=
[ "//build/config/win:default_large_module_incremental_linking" ]
} else {
sources -= [
"../app/chrome_command_ids.h",

Expand Down
1 change: 1 addition & 0 deletions components/user_manager/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ component("user_manager") {
"user_type.h",
]
deps += [
"//base:prefs",
"//chromeos:chromeos",
"//components/session_manager/core",
"//google_apis",
Expand Down
1 change: 1 addition & 0 deletions remoting/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ if (!is_mac) {
deps += [
"//remoting/codec:unit_tests",
"//remoting/host:unit_tests",
"//ui/gfx",
]
}

Expand Down
1 change: 1 addition & 0 deletions remoting/host/it2me/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ if (!is_win && enable_remoting_host) {
"//remoting/host",
"//remoting/host/native_messaging",
"//remoting/proto",
"//ui/gfx",
]

if (enable_webrtc) {
Expand Down

0 comments on commit 1562114

Please sign in to comment.