Skip to content

Commit

Permalink
Enable the following tests under Mac ASan:
Browse files Browse the repository at this point in the history
 - FoundationUtilTest.NSStringToFilePath
 - BrowserAccessibilityTest.BasicAttributeTest

BUG=173983
R=dmazzoni@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/26887007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229408 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
glider@chromium.org committed Oct 18, 2013
1 parent ecf8cdc commit 16a3356
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions base/mac/foundation_util_unittest.mm
Original file line number Diff line number Diff line change
Expand Up @@ -308,8 +308,7 @@
EXPECT_NSEQ(@"/a/b", FilePathToNSString(FilePath("/a/b")));
}

// http://crbug.com/173983 Fails consistently under Mac ASAN.
TEST(FoundationUtilTest, DISABLED_NSStringToFilePath) {
TEST(FoundationUtilTest, NSStringToFilePath) {
EXPECT_EQ(FilePath(), NSStringToFilePath(nil));
EXPECT_EQ(FilePath(), NSStringToFilePath(@""));
EXPECT_EQ(FilePath("/a/b"), NSStringToFilePath(@"/a/b"));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,7 @@ void RebuildAccessibilityTree() {
}

// Test to ensure querying standard attributes works.
// http://crbug.com/173983 Test fails on Mac ASan bot
TEST_F(BrowserAccessibilityTest, DISABLED_BasicAttributeTest) {
TEST_F(BrowserAccessibilityTest, BasicAttributeTest) {
NSString* helpText = [accessibility_
accessibilityAttributeValue:NSAccessibilityHelpAttribute];
EXPECT_NSEQ(@"HelpText", helpText);
Expand Down

0 comments on commit 16a3356

Please sign in to comment.