Skip to content

Commit

Permalink
Document in //content/DEPS that //content shouldn't depend on //compo…
Browse files Browse the repository at this point in the history
…nents.

I'm working with the owners of the one exception to this rule to find
a correct home for it.

BUG=none

Review URL: https://chromiumcodereview.appspot.com/15490006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201275 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
joi@chromium.org committed May 21, 2013
1 parent a1179d3 commit 175d473
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
4 changes: 2 additions & 2 deletions content/DEPS
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Do NOT add chrome to the list below. We shouldn't be including files from
# src/chrome in src/content.
# Do NOT add chrome or components to the list below. We shouldn't be
# including files from src/chrome or src/components in src/content.
include_rules = [
# The subdirectories in content/ will manually allow their own include
# directories in content/ so we disallow all of them.
Expand Down
8 changes: 6 additions & 2 deletions content/browser/DEPS
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
include_rules = [
"+components/tracing",
"+content/gpu", # For gpu_info_collector.h and in-process GPU
"+content/port/browser",
"+content/public/browser",
Expand All @@ -9,6 +8,11 @@ include_rules = [
"+ui/webui",
"+win8/util",

# TODO(joi): This was misplaced; need to move it somewhere else,
# since //content shouldn't depend on //components, which is a layer
# above.
"+components/tracing",

# Other libraries.
"+third_party/iaccessible2",
"+third_party/isimpledom",
Expand All @@ -22,7 +26,7 @@ include_rules = [

"-webkit/renderer",

# DO NOT ADD ANY CHROME INCLUDES HERE!!!
# DO NOT ADD ANY CHROME OR COMPONENTS INCLUDES HERE!!!
# See https://sites.google.com/a/chromium.org/dev/developers/content-module
# for more information.
]

0 comments on commit 175d473

Please sign in to comment.