[//gpu] Pass ClientSI to GPU thread in SIIInProcess::DestroySI(ClientSI)

In preparation for having ClientSharedImage own its associated GMB, this
CL passes the ClientSI instance given to SIIInProcess::DestroySI() to
the GPU thread. This ensures that it will stay alive until the Mailbox
is destroyed, which is when the GMB should be destroyed (and currently
is destroyed).

Bug: 1500611
Change-Id: I45888538ae024f3666d6ab0874349e3e19aca311
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5028360
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1224797}

gpu/command_buffer/service/shared_image_interface_in_process.cc

@@ -706,7 +706,13 @@ void SharedImageInterfaceInProcess::DestroySharedImage(
     const SyncToken& sync_token,
     scoped_refptr<ClientSharedImage> client_shared_image) {
   CHECK(client_shared_image->HasOneRef());
-  DestroySharedImage(sync_token, client_shared_image->mailbox());
+  // Use sync token dependency to ensure that the destroy task does not run
+  // before sync token is released.
+  ScheduleGpuTask(
+      base::BindOnce(
+          &SharedImageInterfaceInProcess::DestroyClientSharedImageOnGpuThread,
+          base::Unretained(this), std::move(client_shared_image)),
+      {sync_token});
 }
 
 void SharedImageInterfaceInProcess::DestroySharedImageOnGpuThread(
@@ -726,6 +732,11 @@ void SharedImageInterfaceInProcess::DestroySharedImageOnGpuThread(
   }
 }
 
+void SharedImageInterfaceInProcess::DestroyClientSharedImageOnGpuThread(
+    scoped_refptr<ClientSharedImage> client_shared_image) {
+  DestroySharedImageOnGpuThread(client_shared_image->mailbox());
+}
+
 void SharedImageInterfaceInProcess::WaitSyncTokenOnGpuThread(
     const SyncToken& sync_token) {
   DCHECK_CALLED_ON_VALID_SEQUENCE(gpu_sequence_checker_);

gpu/command_buffer/service/shared_image_interface_in_process.h

@@ -243,6 +243,8 @@ class GPU_GLES2_EXPORT SharedImageInterfaceInProcess
   void UpdateSharedImageOnGpuThread(const Mailbox& mailbox,
                                     const SyncToken& sync_token);
   void DestroySharedImageOnGpuThread(const Mailbox& mailbox);
+  void DestroyClientSharedImageOnGpuThread(
+      scoped_refptr<ClientSharedImage> client_shared_image);
   void WaitSyncTokenOnGpuThread(const SyncToken& sync_token);
   void WrapTaskWithGpuUrl(base::OnceClosure task);
   void GetCapabilitiesOnGpu(base::WaitableEvent* completion,