Skip to content

Commit

Permalink
Revert 225020 "Tighten up DEPS rules in src/ui: prevent componen..."
Browse files Browse the repository at this point in the history
> Tighten up DEPS rules in src/ui: prevent components from including from each other, and drop a bunch of DEPS files in to make checkdeps happy.
> 
> BUG=none
> R=sky@chromium.org
> 
> Review URL: https://codereview.chromium.org/24273005

TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/24257013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225032 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
ben@chromium.org committed Sep 24, 2013
1 parent 191a67b commit 197e7f6
Show file tree
Hide file tree
Showing 23 changed files with 1 addition and 89 deletions.
3 changes: 0 additions & 3 deletions ui/DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,4 @@ include_rules = [
"+skia",
"+third_party/mozilla",
"+third_party/skia",

# Components within ui must state their dependencies explicitly.
"-ui",
]
4 changes: 0 additions & 4 deletions ui/android/DEPS

This file was deleted.

5 changes: 0 additions & 5 deletions ui/aura/DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,5 @@ include_rules = [
"+grit/ui_strings.h",
"+skia/ext",
"+ui/base",
"+ui/compositor",
"+ui/events",
"+ui/gfx",
"+ui/metro_viewer", # TODO(beng): investigate moving remote_root_window_host
# to ui/metro_viewer.
]

3 changes: 0 additions & 3 deletions ui/aura/test/DEPS

This file was deleted.

7 changes: 0 additions & 7 deletions ui/base/DEPS

This file was deleted.

1 change: 0 additions & 1 deletion ui/base/test/ui_controls_internal_win.cc
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
#include "ui/events/keycodes/keyboard_code_conversion_win.h"
#include "ui/events/keycodes/keyboard_codes.h"

// TODO(beng): wtf is this? layering violation!!!1
#if defined(USE_AURA)
#include "ui/aura/root_window.h"
#include "ui/aura/window.h"
Expand Down
2 changes: 0 additions & 2 deletions ui/compositor/DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,5 @@
include_rules = [
"+cc",
"+third_party/WebKit/public/platform/WebGraphicsContext3D.h",
"+ui/gfx",
"+ui/gl",
"+webkit/common/gpu",
]
4 changes: 0 additions & 4 deletions ui/events/DEPS

This file was deleted.

3 changes: 0 additions & 3 deletions ui/gfx/DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,4 @@ include_rules = [
"+base",
"+skia",
"+third_party/angle",
"+ui/base/ui_export.h", # TODO(beng): remove
"+ui/base/layout.h", # TODO(davemoore): remove
"+ui/test/ui_unittests_resource.h", # TODO(beng): remove
]
3 changes: 0 additions & 3 deletions ui/gl/DEPS
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
include_rules = [
"+third_party/khronos",
"+third_party/mesa/src/include",
"+ui/gfx",

"+ui/base/x/x11_util.h", # TODO(beng): remove after landing 24273005
]
5 changes: 0 additions & 5 deletions ui/keyboard/DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,4 @@ include_rules = [
"+content/public",
"+grit/keyboard_resources.h",
"+grit/keyboard_resources_map.h",
"+ui/aura",
"+ui/base",
"+ui/compositor",
"+ui/gfx",
"+ui/test",
]
8 changes: 0 additions & 8 deletions ui/message_center/DEPS
Original file line number Diff line number Diff line change
@@ -1,11 +1,3 @@
include_rules = [
"+third_party/GTM", # For Mac utility classes.
"+ui/aura",
"+ui/base",
"+ui/compositor",
"+ui/events",
"+ui/gfx",
"+ui/native_theme",
"+ui/test",
"+ui/views",
]
4 changes: 0 additions & 4 deletions ui/metro_viewer/DEPS

This file was deleted.

5 changes: 0 additions & 5 deletions ui/native_theme/DEPS

This file was deleted.

6 changes: 0 additions & 6 deletions ui/shell_dialogs/DEPS

This file was deleted.

4 changes: 1 addition & 3 deletions ui/snapshot/DEPS
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
include_rules = [
"+skia",
"+ui/android",
"+ui/aura",
"+ui/base",
"+ui/compositor",
"+ui/gfx",
"+ui/gl",
]
]
4 changes: 0 additions & 4 deletions ui/surface/DEPS
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
include_rules = [
"+media/base",
"+ui/base",
"+ui/events/latency_info.h",
"+ui/gfx",
"+ui/gl",
]
5 changes: 0 additions & 5 deletions ui/test/DEPS

This file was deleted.

6 changes: 0 additions & 6 deletions ui/views/DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,4 @@ include_rules = [
"+grit/ui_strings.h",
"+skia/ext",
"+third_party/iaccessible2",
"+ui/aura",
"+ui/base",
"+ui/compositor",
"+ui/events",
"+ui/gfx",
"+ui/native_theme",
]
1 change: 0 additions & 1 deletion ui/views/controls/webview/DEPS
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
include_rules = [
"+content/public",
"+ui/views",
"+ui/web_dialogs",
]
3 changes: 0 additions & 3 deletions ui/views/linux_ui/DEPS

This file was deleted.

2 changes: 0 additions & 2 deletions ui/web_dialogs/DEPS
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
include_rules = [
"+content/public",
"+webkit/glue",
"+ui/base",
"+ui/gfx",
]
2 changes: 0 additions & 2 deletions ui/webui/DEPS
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
include_rules = [
"+grit/webui_resources.h",
"+ui/base",
"+ui/gfx",
]

0 comments on commit 197e7f6

Please sign in to comment.