Skip to content

Commit

Permalink
Change jingle_unittests target to a test executable.
Browse files Browse the repository at this point in the history
Everything seems to link now.

Tested with the following command lines:

$ gn gen out-gn
$ ninja -C out-gn/ jingle_unittests
$ out-gn/jingle_unittests

This fixes one more TODO(GYP).

BUG=None
TEST=see above
R=sergeyu@chromium.org

Review URL: https://codereview.chromium.org/929433006

Cr-Commit-Position: refs/heads/master@{#317045}
  • Loading branch information
tfarina authored and Commit bot committed Feb 19, 2015
1 parent 5971c87 commit 1b1006a
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions jingle/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
# found in the LICENSE file.

import("//build/config/features.gni")
import("//testing/test.gni")

if (enable_webrtc || !is_android) {
jingle_includes = exec_script("//build/gypi_to_gn.py",
Expand Down Expand Up @@ -110,9 +111,7 @@ if (enable_webrtc || !is_android) {
}

# GYP version: jingle/jingle.gyp:jingle_unittests
# TODO(GYP): Convert to executable when its dependencies are linkable.
source_set("jingle_unittests") {
testonly = true
test("jingle_unittests") {
sources = [
"glue/channel_socket_adapter_unittest.cc",
"glue/chrome_async_socket_unittest.cc",
Expand Down

0 comments on commit 1b1006a

Please sign in to comment.