[EOC] Move chrome://snippets-internals to its own directory

Moving the backend & frontend code to their own folders. This CL contains no functional changes. Bug: 830931 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia6147c93063214143c8de29ca945cc3df8892bfa Reviewed-on: https://chromium-review.googlesource.com/1023114 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#552896}
Denger-Network · Apr 23, 2018 · 1b4e121 · 1b4e121
1 parent aeacdd5
commit 1b4e121
Show file tree

Hide file tree

Showing 13 changed files with 22 additions and 18 deletions.
diff --git a/chrome/browser/browser_resources.grd b/chrome/browser/browser_resources.grd
@@ -174,9 +174,9 @@
         <include name="IDR_OFFLINE_INTERNALS_CSS" file="resources\offline_pages\offline_internals.css" type="BINDATA" compress="gzip" />
         <include name="IDR_OFFLINE_INTERNALS_JS" file="resources\offline_pages\offline_internals.js" type="BINDATA" compress="gzip" />
         <include name="IDR_OFFLINE_INTERNALS_BROWSER_PROXY_JS" file="resources\offline_pages\offline_internals_browser_proxy.js" type="BINDATA" compress="gzip" />
-        <include name="IDR_SNIPPETS_INTERNALS_HTML" file="resources\snippets_internals.html" allowexternalscript="true" compress="gzip" type="BINDATA" />
-        <include name="IDR_SNIPPETS_INTERNALS_CSS" file="resources\snippets_internals.css" compress="gzip" type="BINDATA" />
-        <include name="IDR_SNIPPETS_INTERNALS_JS" file="resources\snippets_internals.js" compress="gzip" type="BINDATA" />
+        <include name="IDR_SNIPPETS_INTERNALS_HTML" file="resources\snippets_internals\snippets_internals.html" allowexternalscript="true" compress="gzip" type="BINDATA" />
+        <include name="IDR_SNIPPETS_INTERNALS_CSS" file="resources\snippets_internals\snippets_internals.css" compress="gzip" type="BINDATA" />
+        <include name="IDR_SNIPPETS_INTERNALS_JS" file="resources\snippets_internals\snippets_internals.js" compress="gzip" type="BINDATA" />
       </if>
       <include name="IDR_SUPERVISED_USER_INTERNALS_HTML" file="resources\supervised_user_internals.html" allowexternalscript="true" compress="gzip" type="BINDATA" />
       <include name="IDR_SUPERVISED_USER_INTERNALS_CSS" file="resources\supervised_user_internals.css" compress="gzip" type="BINDATA" />

diff --git a/chrome/browser/resources/snippets_internals/OWNERS b/chrome/browser/resources/snippets_internals/OWNERS
@@ -0,0 +1 @@
+file://components/ntp_snippets/OWNERS
diff --git a/.../browser/resources/snippets_internals.css → ...snippets_internals/snippets_internals.css b/.../browser/resources/snippets_internals.css → ...snippets_internals/snippets_internals.css
diff --git a/...browser/resources/snippets_internals.html → ...nippets_internals/snippets_internals.html b/...browser/resources/snippets_internals.html → ...nippets_internals/snippets_internals.html
diff --git a/...e/browser/resources/snippets_internals.js → .../snippets_internals/snippets_internals.js b/...e/browser/resources/snippets_internals.js → .../snippets_internals/snippets_internals.js
diff --git a/chrome/browser/ui/BUILD.gn b/chrome/browser/ui/BUILD.gn
@@ -1209,10 +1209,10 @@ split_static_library("ui") {
       "webui/offline/offline_internals_ui_message_handler.h",
       "webui/physical_web/physical_web_ui.cc",
       "webui/physical_web/physical_web_ui.h",
-      "webui/snippets_internals_message_handler.cc",
-      "webui/snippets_internals_message_handler.h",
-      "webui/snippets_internals_ui.cc",
-      "webui/snippets_internals_ui.h",
+      "webui/snippets_internals/snippets_internals_message_handler.cc",
+      "webui/snippets_internals/snippets_internals_message_handler.h",
+      "webui/snippets_internals/snippets_internals_ui.cc",
+      "webui/snippets_internals/snippets_internals_ui.h",
       "webui/webapks_handler.cc",
       "webui/webapks_handler.h",
       "webui/webapks_ui.cc",

diff --git a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
@@ -119,7 +119,7 @@
 
 #if defined(OS_ANDROID)
 #include "chrome/browser/ui/webui/offline/offline_internals_ui.h"
-#include "chrome/browser/ui/webui/snippets_internals_ui.h"
+#include "chrome/browser/ui/webui/snippets_internals/snippets_internals_ui.h"
 #include "chrome/browser/ui/webui/webapks_ui.h"
 #else
 #include "chrome/browser/ui/webui/devtools_ui.h"

diff --git a/chrome/browser/ui/webui/snippets_internals/OWNERS b/chrome/browser/ui/webui/snippets_internals/OWNERS
@@ -0,0 +1 @@
+file://components/ntp_snippets/OWNERS
diff --git a/...bui/snippets_internals_message_handler.cc → ...als/snippets_internals_message_handler.cc b/...bui/snippets_internals_message_handler.cc → ...als/snippets_internals_message_handler.cc
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "chrome/browser/ui/webui/snippets_internals_message_handler.h"
+#include "chrome/browser/ui/webui/snippets_internals/snippets_internals_message_handler.h"
 
 #include <memory>
 #include <set>

diff --git a/...ebui/snippets_internals_message_handler.h → ...nals/snippets_internals_message_handler.h b/...ebui/snippets_internals_message_handler.h → ...nals/snippets_internals_message_handler.h
@@ -2,8 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROME_BROWSER_UI_WEBUI_SNIPPETS_INTERNALS_MESSAGE_HANDLER_H_
-#define CHROME_BROWSER_UI_WEBUI_SNIPPETS_INTERNALS_MESSAGE_HANDLER_H_
+#ifndef CHROME_BROWSER_UI_WEBUI_SNIPPETS_INTERNALS_SNIPPETS_INTERNALS_MESSAGE_HANDLER_H_
+#define CHROME_BROWSER_UI_WEBUI_SNIPPETS_INTERNALS_SNIPPETS_INTERNALS_MESSAGE_HANDLER_H_
 
 #include <map>
 #include <string>
@@ -115,4 +115,4 @@ class SnippetsInternalsMessageHandler
   DISALLOW_COPY_AND_ASSIGN(SnippetsInternalsMessageHandler);
 };
 
-#endif  // CHROME_BROWSER_UI_WEBUI_SNIPPETS_INTERNALS_MESSAGE_HANDLER_H_
+#endif  // CHROME_BROWSER_UI_WEBUI_SNIPPETS_INTERNALS_SNIPPETS_INTERNALS_MESSAGE_HANDLER_H_
diff --git a/...browser/ui/webui/snippets_internals_ui.cc → ...ippets_internals/snippets_internals_ui.cc b/...browser/ui/webui/snippets_internals_ui.cc → ...ippets_internals/snippets_internals_ui.cc
@@ -2,14 +2,14 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "chrome/browser/ui/webui/snippets_internals_ui.h"
+#include "chrome/browser/ui/webui/snippets_internals/snippets_internals_ui.h"
 
 #include <memory>
 
 #include "build/build_config.h"
 #include "chrome/browser/ntp_snippets/content_suggestions_service_factory.h"
 #include "chrome/browser/profiles/profile.h"
-#include "chrome/browser/ui/webui/snippets_internals_message_handler.h"
+#include "chrome/browser/ui/webui/snippets_internals/snippets_internals_message_handler.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/grit/browser_resources.h"
 #include "content/public/browser/web_ui.h"
@@ -33,7 +33,7 @@ content::WebUIDataSource* CreateSnippetsInternalsHTMLSource() {
   return source;
 }
 
-} // namespace
+}  // namespace
 
 SnippetsInternalsUI::SnippetsInternalsUI(content::WebUI* web_ui)
     : WebUIController(web_ui) {

diff --git a/.../browser/ui/webui/snippets_internals_ui.h → ...nippets_internals/snippets_internals_ui.h b/.../browser/ui/webui/snippets_internals_ui.h → ...nippets_internals/snippets_internals_ui.h
@@ -2,8 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROME_BROWSER_UI_WEBUI_SNIPPETS_INTERNALS_UI_H_
-#define CHROME_BROWSER_UI_WEBUI_SNIPPETS_INTERNALS_UI_H_
+#ifndef CHROME_BROWSER_UI_WEBUI_SNIPPETS_INTERNALS_SNIPPETS_INTERNALS_UI_H_
+#define CHROME_BROWSER_UI_WEBUI_SNIPPETS_INTERNALS_SNIPPETS_INTERNALS_UI_H_
 
 #include "base/macros.h"
 #include "content/public/browser/web_ui_controller.h"
@@ -18,4 +18,4 @@ class SnippetsInternalsUI : public content::WebUIController {
   DISALLOW_COPY_AND_ASSIGN(SnippetsInternalsUI);
 };
 
-#endif  // CHROME_BROWSER_UI_WEBUI_SNIPPETS_INTERNALS_UI_H_
+#endif  // CHROME_BROWSER_UI_WEBUI_SNIPPETS_INTERNALS_SNIPPETS_INTERNALS_UI_H_
diff --git a/components/ntp_snippets/OWNERS b/components/ntp_snippets/OWNERS
@@ -13,3 +13,5 @@ vitaliii@chromium.org
 
 # For ios:
 noyau@chromium.org
+
+# COMPONENT: UI>Browser>ContentSuggestions