Cleanup owners files, src code.

Remove ygorshenin@ from OWNERS/TODOs, replace with alemate/antrim/dpolukhin/bartfab BUG=None TBR=stevenjb@chromium.org,isherman@chromium.org Review URL: https://codereview.chromium.org/925963002 Cr-Commit-Position: refs/heads/master@{#316554}
Denger-Network · Feb 17, 2015 · 1b9ac7d · 1b9ac7d
1 parent 2a8444b
commit 1b9ac7d
Show file tree

Hide file tree

Showing 23 changed files with 27 additions and 59 deletions.
diff --git a/WATCHLISTS b/WATCHLISTS
@@ -834,8 +834,7 @@
     'battery_status': ['timvolodine@chromium.org'],
     'bookmarks': ['noyau+watch@chromium.org', 'tfarina@chromium.org'],
     'browser_chromeos': ['davemoore+watch@chromium.org',
-                         'stevenjb+watch@chromium.org',
-                         'nkostylev+watch@chromium.org'],
+                         'stevenjb+watch@chromium.org'],
     'browser_components': ['browser-components-watch@chromium.org'],
     'browser_compositor': ['vollick@chromium.org',
                            'piman+watch@chromium.org'],

diff --git a/chrome/browser/chromeos/login/OWNERS b/chrome/browser/chromeos/login/OWNERS
@@ -1,7 +1,6 @@
 nkostylev@chromium.org
 dpolukhin@chromium.org
 piman@chromium.org
-ygorshenin@chromium.org
 antrim@chromium.org
 dzhioev@chromium.org
 alemate@chromium.org
diff --git a/chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc b/chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc
@@ -306,7 +306,7 @@ void SimpleWebViewDialog::ShowWebsiteSettings(
     const GURL& url,
     const content::SSLStatus& ssl) {
   NOTIMPLEMENTED();
-  // TODO (ygorshenin@,markusheintz@): implement this
+  // TODO (markusheintz@): implement this
 }
 
 PageActionImageView* SimpleWebViewDialog::CreatePageActionImageView(

diff --git a/chrome/browser/chromeos/login/users/multi_profile_user_controller_unittest.cc b/chrome/browser/chromeos/login/users/multi_profile_user_controller_unittest.cc
@@ -322,23 +322,6 @@ TEST_F(MultiProfileUserControllerTest, PrimaryBehaviorChange) {
   }
 }
 
-// Tests that owner could not be a secondary user.
-//
-// TODO (ygorshenin@, crbug.com/230018): remove or change the test when the
-// issue will be fixed.
-TEST_F(MultiProfileUserControllerTest, DISABLED_NoSecondaryOwner) {
-  LoginUser(0);
-  SetOwner(1);
-
-  MultiProfileUserController::UserAllowedInSessionReason reason;
-  EXPECT_FALSE(controller()->IsUserAllowedInSession(kUsers[1], &reason));
-  EXPECT_EQ(MultiProfileUserController::NOT_ALLOWED_OWNER_AS_SECONDARY, reason);
-
-  EXPECT_EQ(0, user_not_allowed_count());
-  LoginUser(1);
-  EXPECT_EQ(1, user_not_allowed_count());
-}
-
 TEST_F(MultiProfileUserControllerTest,
        UsedPolicyCertificatesAllowedForPrimary) {
   // Verifies that any user can sign-in as the primary user, regardless of the

diff --git a/chrome/browser/chromeos/login/wizard_controller.cc b/chrome/browser/chromeos/login/wizard_controller.cc
@@ -248,15 +248,12 @@ void WizardController::Init(const std::string& first_screen_name) {
 
   // This is a hacky way to check for local state corruption, because
   // it depends on the fact that the local state is loaded
-  // synchroniously and at the first demand. IsEnterpriseManaged()
+  // synchronously and at the first demand. IsEnterpriseManaged()
   // check is required because currently powerwash is disabled for
-  // enterprise-entrolled devices.
+  // enterprise-enrolled devices.
   //
   // TODO (ygorshenin@): implement handling of the local state
   // corruption in the case of asynchronious loading.
-  //
-  // TODO (ygorshenin@): remove IsEnterpriseManaged() check once
-  // crbug.com/241313 will be fixed.
   policy::BrowserPolicyConnectorChromeOS* connector =
       g_browser_process->platform_part()->browser_policy_connector_chromeos();
   if (!connector->IsEnterpriseManaged()) {

diff --git a/chrome/browser/chromeos/net/OWNERS b/chrome/browser/chromeos/net/OWNERS
@@ -2,6 +2,5 @@ per-file cert_verify_proc*=mattm@chromium.org
 per-file cert_verify_proc*=rsleevi@chromium.org
 per-file client_cert_filter*=mattm@chromium.org
 per-file client_cert_filter*=rsleevi@chromium.org
-per-file network_portal*=ygorshenin@chromium.org
 per-file onc_utils*=pneubeck@chromium.org
 per-file proxy_config_handler*=pneubeck@chromium.org
diff --git a/chrome/browser/chromeos/ownership/OWNERS b/chrome/browser/chromeos/ownership/OWNERS
diff --git a/chrome/browser/chromeos/reset/OWNERS b/chrome/browser/chromeos/reset/OWNERS
@@ -2,4 +2,3 @@ dpolukhin@chromium.org
 dzhioev@chromium.org
 merkulova@chromium.org
 nkostylev@chromium.org
-ygorshenin@chromium.org
diff --git a/chrome/browser/chromeos/settings/OWNERS b/chrome/browser/chromeos/settings/OWNERS
@@ -1,2 +1,2 @@
 mnissler@chromium.org
-ygorshenin@chromium.org
+bartfab@chromium.org
diff --git a/chrome/browser/resources/chromeos/login/OWNERS b/chrome/browser/resources/chromeos/login/OWNERS
@@ -1,5 +1,4 @@
 nkostylev@chromium.org
 dpolukhin@chromium.org
-ygorshenin@chromium.org
 antrim@chromium.org
 dzhioev@chromium.org
diff --git a/chrome/browser/ui/webui/chromeos/login/OWNERS b/chrome/browser/ui/webui/chromeos/login/OWNERS
@@ -2,4 +2,3 @@ antrim@chromium.org
 dpolukhin@chromium.org
 dzhioev@chromium.org
 nkostylev@chromium.org
-ygorshenin@chromium.org
diff --git a/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h b/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h
@@ -95,7 +95,7 @@ class GaiaScreenHandler : public BaseScreenHandler {
   net::Error frame_error() const { return frame_error_; }
 
  private:
-  // TODO (ygorshenin@): remove this dependency.
+  // TODO (antrim@): remove this dependency.
   friend class SigninScreenHandler;
 
   // BaseScreenHandler implementation:
@@ -186,11 +186,11 @@ class GaiaScreenHandler : public BaseScreenHandler {
   // extension should be used.
   void LoadAuthExtension(bool force, bool silent_load, bool offline);
 
-  // TODO (ygorshenin@): GaiaScreenHandler should implement
+  // TODO (antrim@): GaiaScreenHandler should implement
   // NetworkStateInformer::Observer.
   void UpdateState(NetworkError::ErrorReason reason);
 
-  // TODO (ygorshenin@): remove this dependency.
+  // TODO (antrim@): remove this dependency.
   void SetSigninScreenHandler(SigninScreenHandler* handler);
 
   SigninScreenHandlerDelegate* Delegate();
@@ -254,7 +254,7 @@ class GaiaScreenHandler : public BaseScreenHandler {
 
   // Non-owning ptr to SigninScreenHandler instance. Should not be used
   // in dtor.
-  // TODO (ygorshenin@): GaiaScreenHandler shouldn't communicate with
+  // TODO (antrim@): GaiaScreenHandler shouldn't communicate with
   // signin_screen_handler directly.
   SigninScreenHandler* signin_screen_handler_;
 

diff --git a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
@@ -611,12 +611,12 @@ void SigninScreenHandler::UpdateUIState(UIState ui_state,
   }
 }
 
-// TODO(ygorshenin@): split this method into small parts.
-// TODO(ygorshenin@): move this logic to GaiaScreenHandler.
+// TODO(antrim@): split this method into small parts.
+// TODO(antrim@): move this logic to GaiaScreenHandler.
 void SigninScreenHandler::UpdateStateInternal(NetworkError::ErrorReason reason,
                                               bool force_update) {
   // Do nothing once user has signed in or sign in is in progress.
-  // TODO(ygorshenin): We will end up here when processing network state
+  // TODO(antrim): We will end up here when processing network state
   // notification but no ShowSigninScreen() was called so delegate_ will be
   // NULL. Network state processing logic does not belong here.
   if (delegate_ &&

diff --git a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h
@@ -454,7 +454,7 @@ class SigninScreenHandler
   bool caps_lock_enabled_;
 
   // Non-owning ptr.
-  // TODO(ygorshenin@): remove this dependency.
+  // TODO(antrim@): remove this dependency.
   GaiaScreenHandler* gaia_screen_handler_;
 
   // Maximized mode controller delegate.

diff --git a/chromeos/login/OWNERS b/chromeos/login/OWNERS
@@ -1,6 +1,5 @@
 nkostylev@chromium.org
 dpolukhin@chromium.org
 piman@chromium.org
-ygorshenin@chromium.org
 antrim@chromium.org
 dzhioev@chromium.org
diff --git a/chromeos/network/portal_detector/OWNERS b/chromeos/network/portal_detector/OWNERS
@@ -1 +1,2 @@
-ygorshenin@chromium.org
+dpolukhin@chromium.org
+alemate@chromium.org
diff --git a/components/OWNERS b/components/OWNERS
@@ -205,7 +205,6 @@ per-file session_manager.gypi=antrim@chromium.org
 per-file session_manager.gypi=dpolukhin@chromium.org
 per-file session_manager.gypi=dzhioev@chromium.org
 per-file session_manager.gypi=nkostylev@chromium.org
-per-file session_manager.gypi=ygorshenin@chromium.org
 
 per-file sessions.gypi=marja@chromium.org
 per-file sessions.gypi=sky@chromium.org
@@ -247,7 +246,6 @@ per-file user_manager.gypi=antrim@chromium.org
 per-file user_manager.gypi=dpolukhin@chromium.org
 per-file user_manager.gypi=dzhioev@chromium.org
 per-file user_manager.gypi=nkostylev@chromium.org
-per-file user_manager.gypi=ygorshenin@chromium.org
 
 per-file url_fixer.gypi=pkasting@chromium.org
 

diff --git a/components/login/OWNERS b/components/login/OWNERS
@@ -5,4 +5,3 @@ dpolukhin@chromium.org
 dzhioev@chromium.org
 nkostylev@chromium.org
 piman@chromium.org
-ygorshenin@chromium.org
diff --git a/components/ownership/OWNERS b/components/ownership/OWNERS
@@ -1 +1,2 @@
-ygorshenin@chromium.org
+alemate@chromium.org
+dpolukhin@chromium.org
diff --git a/components/session_manager/OWNERS b/components/session_manager/OWNERS
@@ -2,4 +2,3 @@ nkostylev@chromium.org
 antrim@chromium.org
 dpolukhin@chromium.org
 dzhioev@chromium.org
-ygorshenin@chromium.org
diff --git a/components/user_manager/OWNERS b/components/user_manager/OWNERS
@@ -2,4 +2,3 @@ nkostylev@chromium.org
 antrim@chromium.org
 dpolukhin@chromium.org
 dzhioev@chromium.org
-ygorshenin@chromium.org
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
@@ -2185,7 +2185,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
 
 <histogram name="CaptivePortal.Notification.Status"
     enum="CaptivePortalNotificationStatus">
-  <owner>ygorshenin@chromium.org</owner>
+  <owner>alemate@chromium.org</owner>
   <summary>
     Count of displayed and not displayed due to errors notifications about
     captive portal.
@@ -2194,14 +2194,14 @@ Therefore, the affected-histogram name has to have at least one dot in it.
 
 <histogram name="CaptivePortal.Notification.UserAction"
     enum="CaptivePortalNotificationUserAction">
-  <owner>ygorshenin@chromium.org</owner>
+  <owner>alemate@chromium.org</owner>
   <summary>
     Count of clicked, closed and ignored captive portal notifications.
   </summary>
 </histogram>
 
 <histogram name="CaptivePortal.OOBE.DetectionDuration" units="milliseconds">
-  <owner>ygorshenin@chromium.org</owner>
+  <owner>alemate@chromium.org</owner>
   <summary>
     Duration of the captive portal detection process for a particular network at
     OOBE. Detection duration is recorded each time portal detection is completed
@@ -2210,7 +2210,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
 </histogram>
 
 <histogram name="CaptivePortal.OOBE.DetectionResult" enum="CaptivePortalStatus">
-  <owner>ygorshenin@chromium.org</owner>
+  <owner>alemate@chromium.org</owner>
   <summary>
     The result of captive portal detection attempts performed at OOBE. Detection
     result is recorded when portal detection is completed for an active network
@@ -2220,7 +2220,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
 
 <histogram name="CaptivePortal.OOBE.DiscrepancyWithShill"
     enum="CaptivePortalStatus">
-  <owner>ygorshenin@chromium.org</owner>
+  <owner>alemate@chromium.org</owner>
   <summary>
     The result of captive portal detection attempts at OOBE if it diverges from
     network manager results. Detection result is recorded each time portal
@@ -2230,15 +2230,15 @@ Therefore, the affected-histogram name has to have at least one dot in it.
 
 <histogram name="CaptivePortal.OOBE.PortalToOnlineTransition"
     units="milliseconds">
-  <owner>ygorshenin@chromium.org</owner>
+  <owner>alemate@chromium.org</owner>
   <summary>
     Number of milliseconds passed between consecutive reports for the same
     network about portal and online states.
   </summary>
 </histogram>
 
 <histogram name="CaptivePortal.Session.DetectionDuration" units="milliseconds">
-  <owner>ygorshenin@chromium.org</owner>
+  <owner>alemate@chromium.org</owner>
   <summary>
     Duration of the captive portal detection process for a particular network in
     user session. Detection duration is recorded each time portal detection is
@@ -2248,7 +2248,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
 
 <histogram name="CaptivePortal.Session.DetectionResult"
     enum="CaptivePortalStatus">
-  <owner>ygorshenin@chromium.org</owner>
+  <owner>alemate@chromium.org</owner>
   <summary>
     The result of captive portal detection attempts performed in user session.
     Detection result is recorded when portal detection is completed for an
@@ -2259,7 +2259,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
 
 <histogram name="CaptivePortal.Session.DiscrepancyWithShill"
     enum="CaptivePortalStatus">
-  <owner>ygorshenin@chromium.org</owner>
+  <owner>alemate@chromium.org</owner>
   <summary>
     The result of captive portal detection attempts in session if it diverges
     from network manager results. Detection result is recorded each time portal
@@ -2269,7 +2269,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
 
 <histogram name="CaptivePortal.Session.PortalToOnlineTransition"
     units="milliseconds">
-  <owner>ygorshenin@chromium.org</owner>
+  <owner>alemate@chromium.org</owner>
   <summary>
     Number of milliseconds passed between consecutive reports for the same
     network about portal and online states.

diff --git a/ui/login/OWNERS b/ui/login/OWNERS
@@ -1,6 +1,5 @@
 nkostylev@chromium.org
 dpolukhin@chromium.org
-ygorshenin@chromium.org
 antrim@chromium.org
 dzhioev@chromium.org
 merkulova@chromium.org