Skip to content

Commit

Permalink
[Extensions UI Mac] Use frameAfterAnimation for extension action butt…
Browse files Browse the repository at this point in the history
…on opacity

Button opacity for extension actions is set when the container frame changes,
but if the button is also animating, we need to use the final frame to determine
the proper opacity.

BUG=530820

Review URL: https://codereview.chromium.org/1346443002

Cr-Commit-Position: refs/heads/master@{#348696}
  • Loading branch information
rdcronin authored and Commit bot committed Sep 14, 2015
1 parent e345caf commit 1be0365
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -668,7 +668,7 @@ - (BOOL)updateContainerVisibility {

- (void)updateButtonOpacity {
for (BrowserActionButton* button in buttons_.get()) {
NSRect buttonFrame = [button frame];
NSRect buttonFrame = [button frameAfterAnimation];
if (NSContainsRect([containerView_ bounds], buttonFrame)) {
if ([button alphaValue] != 1.0)
[button setAlphaValue:1.0];
Expand Down

0 comments on commit 1be0365

Please sign in to comment.